Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Payment
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2017 at 10:57 UTC
Updated:
29 Mar 2018 at 12:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sorabh.v6Patch is uploaded with the code to print the link of the add payment gateway in the drupal message. Please review.
Thanks
Comment #3
heddnLooks good to me.
Comment #4
vdenis commentedI've tested the patch and it looks good for me too.
Comment #5
bojanz commented#2917372: incorrect use of translation in CartEventSubscriber tells us that this is the wrong way to do a link inside t(). Let's follow its suggestion.
Comment #6
sorabh.v6Comment #7
sorabh.v6Hi,
Code updated, please review the updated patch.
Thanks
Comment #8
sorabh.v6Wrong patch file update in the previous comment. This comment has the correct patchfile.
Thanks
Comment #10
heddnGood feedback in #5. This looks good to go now.
Comment #11
bojanz commentedCore uses : instead of @ for urls.
Comment #12
sorabh.v6Changes made as suggested in #11. Please review the updated patch.
Comment #14
drugan commentedMay be test is failed because you should do this instead of the latest changes:
Comment #15
sorabh.v6Thanks @drugan. Code updated as suggested in #14. Please review.
Comment #16
mglamanWe need test coverage in a Functional test.
Comment #17
mglamanMy local is screwing up, here's a pass at a test.
Comment #18
mglamanWhoops, forgot the admin permission.
Comment #19
mglamanbojanz: thoughts? I wasn't sure at first since it links to admin. But I highly doubt someone will launch like this :) And it improves the developer/site builder experience.
Comment #20
bojanz commentedDiscussed points:
1) We might have gateways, but none of their conditions passed. "available" is the word we want to use, not "defined".
2) We need to account for the user possibly not having permissions to manage gateways (hence, we need two different messages).
Comment #21
bojanz commentedComment #23
bojanz commentedTweaked as discussed and committed. Thanks, everyone.