Remove all 404 from list

I would also be interested how I could clear the list to start logging from scratch. A while after the launch we added some redirect patterns, so many of the logged entries should be obsolete now.

Thanks for any help!

Yes, patches that add a button somewhere that executes a truncate query would be great. Maybe on the settings form as we already have a form there.

Hi,

I have added a Reset button in the existing Settings Form. On clicking the same will truncate all the 404 data from the database.

Adding the patch. Please Review.

Thanks

Sorry, Removed the unwanted Use statement.

Thanks

1. +++ b/modules/redirect_404/redirect_404.module
   @@ -35,6 +35,12 @@ function redirect_404_form_redirect_settings_form_alter(&$form, FormStateInterfa
    
   +  $form['reset_404'] = [
   +    '#type' => 'submit',
   +    '#value' => 'Reset 404',
   +    '#submit' => ['reset404'],
   +  ];
   

   The value must use to t() to be translatable. It should also explain more clearly what it does, e.g. "Clear all 404 log entries".

2. +++ b/modules/redirect_404/redirect_404.module
   @@ -94,3 +100,13 @@ function redirect_404_redirect_presave(Redirect $redirect) {
   +/**
   + * Submit Handler for Reseting all the 404 logs from Database.
   + *
   + * @return \Drupal\Core\Database\StatementInterface|int|null
   + */
   +function reset404() {
   +  $query = \Drupal::database()->truncate('redirect_404')->execute();
   +  return $query;
   +}
   

   Submit callbacks don't return anything, there is no need for that.

   Also, all functions must be prefixed with the module name and as a submit function, should have a submit suffix, e.g. redirect_404_reset_submit()

Sorry, work patch

@berdir, I noticed we still do a lot of hook_form_FORM_ID_alter(), it would be nice if there was a more object oriented way to alter form objects. Would it be an option to extend the RedirectSettingsForm and alter the route to the extended one? Or is this a bad idea as something else may have changed it before?

@pifagor #11, I'd use just one capital here and resetting has two t's:

 + * Submit Handler for Reseting all the 404 logs from Database.

 + * Submit handler for resetting all the 404 logs from the database.

form alter is fine here. Altering the route is way more complex and only one module can do that. This is a common pattern to add additional settings to forms provided by other modules.

Lets add some test coverage for this, shouldn't be complicated, in the existing tests after testing the UI, press the button and then check that the empty message is displayed.

I added appropriate Tests for the "Clear all 404 log entries" button as suggested by @Berdir in #14 See MR above

Until this is commited you can use:
https://git.drupalcode.org/project/redirect/-/merge_requests/4.patch
as patch.

Updated the MR to also contain the patch by @pifagor from #11. RTBC +1 from my perspective, well done @pifagor & @Grevil! :)

Let's bring this to a successful end :) Please review finally, I guess it's ready for takeoff.

Hi,
I tested the patch and it is working as expected.
I was looking for such thing for a long time.
Can we make a new release?

Thank you @Petr Illek so let's finally RTBC this issue.

Thanks, committed.