Views RSS row plugin incorrectly assumes links are relative

Works for me (8.5.3)

The patch works for me as well (8.6.3)

I've had a similar problem with the RSS formatter messing up links. A link like https://example.com/insights/news/news-article was being output as https://example.com/news/news-article. So this renders the RSS feed unusable, and checking "Use absolute link" causes the issue with the external link.

The way I've managed to fix this (which I don't like), is to check "Output the URL as text" for the "Link to content" field. Then under "Rewrite results" select "Override the output of this field with custom text", and enter "/ /{{ view_node }}".

This looks to me like a URL being exploded by "/" and the wrong segment being stripped perhaps. Hope this helps someone.

Updated patch for 8.7.x.

Ignore patch #12, it broke other items. Trying this patch instead.

@jennypanighetti I am changing the status to needs review, Sot that the test will against your new patch.

Thanks,
Rakesh James

reroll for core v8.7.7.

patch seems to be giving error at error: patch failed: core/modules/views/src/Plugin/views/row/RssFields.php:6

The patches seem to be mixed up. This is a re-roll against the latest 8.7.x.

That patch failed for me:

Hunk #1 FAILED at 4.
Hunk #2 FAILED at 142.
Hunk #3 succeeded at 270 with fuzz 1 (offset 56 lines).

I attach interdiff file for last two patches(#19 and #21).

The same interdiff as in #22, just changed name to be proper.

I don't think #2673980 resolved the issue. On a fresh build of 8.9.* I'm still getting the error. Here's how I can create it.

* Fresh install of Drupal 8.9.x
* Add a link field to a content type. Allow it to contain external links
* Add content with external links in that field
* Create a view with a Feed display
* Format Show Fields
* Add the required fields (title, my link field, body, authored by authored on)
* Configure the row style options, with Content: my link field as the link field (and the rest as figured)
* Add a path and save
* Observe the following error when trying to access the feed url:

InvalidArgumentException: The internal path component 'http://example.com' is external. You are not allowed to specify an external URL together with internal:/. in Drupal\Core\Url::fromInternalUri() (line 411 of core/lib/Drupal/Core/Url.php).
Drupal\Core\Url::fromUri('internal:/http://example.com', Array) (Line: 210)
Drupal\Core\Url::fromUserInput('/http://example.com') (Line: 228)
Drupal\views\Plugin\views\row\RssFields->getAbsoluteUrl(Object) (Line: 142)
Drupal\views\Plugin\views\row\RssFields->render(Object) (Line: 121)
Drupal\views\Plugin\views\style\Rss->render(Array) (Line: 152)
Drupal\views\Plugin\views\display\Feed->render() (Line: 1533)
Drupal\views\ViewExecutable->render() (Line: 128)
Drupal\views\Plugin\views\display\Feed->execute() (Line: 1630)
Drupal\views\ViewExecutable->executeDisplay('feed_1', Array) (Line: 77)
Drupal\views\Element\View::preRenderViewElement(Array)
call_user_func_array(Array, Array) (Line: 100)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725', 'silenced_deprecation', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 781)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 372)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 144)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 145)
Drupal\Core\Render\Renderer->renderRoot(Array) (Line: 109)
Drupal\views\Plugin\views\display\Feed::buildResponse('test', 'feed_1', Array) (Line: 53)
Drupal\views\Routing\ViewPageController->handle('test', 'feed_1', Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Okay. I took what @jennypanighetti did in #21 and re-rolled it for 8.9.x. I also found the same/similar issue if you use the link as the guid, so I added that in. Hopefully I formatted this patch correctly.

Of course a composer build doesn't give the right base for the patch file. Trying this one.

Adding #3090267: Improve behaviour of RSS view with fields if you enabled "Use absolute link" as another related. That might be duplicate with this -- I didn't see this issue when I submitted that one as a follow-up to #2673980: RSS view with fields give wrong URL from path field.

No time to closely review all this just yet, but I'll try to look soon.

Thanks,
-Derek

I have the opposite problem. I set my RSS feed up years ago and it's worked fine while my RSS publisher published fully qualified URLS. They suddenly switched to publishing relative paths, and now my system broke with the same error in OP.

Re-rolled patch #28 for Drupal 8.8.x (starting from 8.8.5)

The patch couldn't be applied on 9.x.

Tagging "Needs tests" to confirm that the bug is present & needs a patch to fix.

Re-roll patch created for 9.1.x, Please review.

#36 works for me.
Thank you vsujeetkumar!

Drupal core 8.9.2

Configured the Link field of the View like this:

1. +++ b/core/modules/views/src/Plugin/views/row/RssFields.php
   @@ -6,6 +6,7 @@
   @@ -58,7 +59,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   
   @@ -58,7 +59,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
        $form['link_field'] = [
          '#type' => 'select',
          '#title' => $this->t('Link field'),
   -      '#description' => $this->t('The field that is going to be used as the RSS item link for each row. This must either be an internal unprocessed path like "node/123" or a processed, root-relative URL as produced by fields like "Link to content".'),
   +      '#description' => $this->t('The field that is going to be used as the RSS item link for each row.'),
          '#options' => $view_fields_labels,
          '#default_value' => $this->options['link_field'],
          '#required' => TRUE,
   

   #36 is missing this hunk from #33, which should have been preserved. EDIT: Nope, sorry. This patch shouldn't touch that description (which I helped add!). Ignore this point.

2. +++ b/core/modules/views/src/Plugin/views/row/RssFields.php
   @@ -156,7 +164,14 @@ public function render($row) {
   +      // If guid is internal link, get absolute URL from URI
   

   If the guid is an internal link, get the absolute URL from the URI.

3. #NeedsTests. ;)

Cheers,
-Derek

Thank you; #36 worked for me

Worked on #38. Please have a look.
#38.1: Ignore this point as mentioned in #38.
#38.2: Changes has been done.

Re-test the last patch, Moved to NR. Please have a look.

Was tagged for tests in #34 which still needs to happen.

Did not test patch.

#42 Patch works for me (9.5.5 PHP 8.1) for a site running the Domain module. One caveat is that if you have Twig debugging enabled the field comments will passed into fromURI() which isn't a problem on production sites.
InvalidArgumentException: The URI ' <!-- THEME DEBUG --> <!-- THEME HOOK: 'views_view_field' --> <!-- BEGIN OUTPUT from 'core/themes/stable/templates/views/views-view-field.html.twig' -->

Attached patch is a small code cleanup to not duplicate calling $this->getField($row_index, $this->options['link_field']) twice.

Oops, this fixes a syntax error.

Updated patch with further cleanup of duplicate calls to $this->getField($row_index, $this->options['link_field'])

The attached patch will fix the errors with twig debugging enabled. Core without this patch would not error but would create urls were invalid - "http://www.mysite.com/%20%3C%21--%20THEME%20DEBUG%20--%3E%20%3C%21--%20T..."

Pending: new test to test an external url used for the RSS link.

The attached patches add the new feed field test to check field configured to output an absolute URL.

• "2918784-55--fix-and-tests.patch": This is the fix from #54 along with the new tests. This should PASS.
• "2918784-55--tests-only.patch": This is 11.x with the new tests. This should FAIL.

NOTE: The patch "2918784-55--fix-and-tests.patch" also applies to 10.1.x.

Issue summary should be updated, not super clear what the proposed solution is.

Added the template to be filled in by someone familiar with the issue.

Removing tests tag as #56 shows they were added.

Removing IS update tag as that was completed in #59

Following the steps in the IS I was able to reproduce the issue
Patch #58 did solve it, and reran the tests for php8.2 and think failure was unrelated.
Also tests-only patch was provided in #58 that shows the issue.

Think this one is good.

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

I created the following MRs: with 2918784-55--fix-and-tests.patch
11.x: MR 5437
10.1.x: MR 5438

Added some feedback to the MR.

I'm getting an error that You are not allowed to specify an external URL together with internal:/. in Drupal\Core\Url::fromInternalUri() which is annoying because that's exactly what I want to do: our feeds may link to content on the same domain using the view_node internal link to content, or on one of our other domains using a link field which may contain an external absolute link.

The #15 fix on Improve behavior of RSS view with fields if you enabled "Use absolute link" lets me mix'n'match as I need to by allowing valid absolute links to pass right through the getAbsoluteUrl function.

There's obviously a lot more going on in this MR but I'm hoping that at the end of the day, I can be allowed to specify external URLs together with internal. Thanks!

the following MR's have been updated per the MR feedback on MR 5438:
11.x: MR 5437
10.1.x: MR 5438

attached a 11.x static patch for composer builds

Hiding the 10.1 so we just have the 11.x MR.

For the comments around using trim() and striptags()

Depending on the views configuration, the $this->getField($row_index, $this->options['link_field']); could return markup.

If this is needed for the fix believe we maybe should have coverage also around when markup is used. To show that it is indeed needed.

Thanks.

I just upgraded to 10.3.x and it said the patch failed.. which one should I use for 10.3.1?

Any updates on this?

I'm using a Link field in an RSS feed view and have it set to display "link only" and "show URL as plain text" and I am still getting the error as drupal is expecting a relative link.

Can we not use absolute (external) urls in RSS feeds? I think that option should be available.

Using drupal 10.4.6