Child issue of #2860796: Plan for contributed modules with Media Entity API in core

This module depends on Media Entity, so if we want it to be used with Media in core, a new branch will be necessary.

CommentFileSizeAuthor
#13 meb-2906068.patch4.98 KBlarowlan
#13 interdiff.2906068.txt2.14 KBlarowlan
#9 create_a_new_branch-2906068-9.patch4.2 KBmglaman
#2 media_entity_browser-2906068-2.patch2.48 KBgarphy

Comments

marcoscano created an issue. See original summary.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
StatusFileSize
new media_entity_browser-2906068-2.patch2.48 KB

Here's a quick attempt to switch the dependencies from media_entity to media and make it work.

I did not attempted to reviews the tests for now.

BarisW’s picture

BarisW commented
Status: Active » Needs review
sam152’s picture

sam152 commented
Status: Needs review » Needs work
Issue tags: +Needs manual testing

Don't think I fully trust the test coverage for this one.

goz’s picture

goz commented

I make the same changes but have issue:

Error: Call to a member function getConfigDependencyKey() on null in Drupal\entity_browser\Plugin\EntityBrowser\Widget\View->calculateDependencies() (line 277 of modules/contrib/entity_browser/src/Plugin/EntityBrowser/Widget/View.php).
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Confirming #5. Crashes on install.

goz’s picture

goz commented

My bad, this works based on 8.x-1.x-dev like defined in issue description

on 8.x-1.x-dev, entity_browser.browser.media_entity_browser.yml set the config as explained by #2845037: Fix the call to a member function getConfigDependencyKey() on null on Widget view and SelectionDisplay view 

dependencies:
  config:
    - views.view.media_entity_browser
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

When using dev for #7 tests have the error

1) Drupal\Tests\panopoly_media\Kernel\ConfigInstallTest::testInstall
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.media_entity_browser with the following errors: views.view.media_entity_browser:display.default.display_options.fields.media_bulk_form.action_title missing schema, views.view.media_entity_browser:display.default.display_options.fields.media_bulk_form.include_exclude missing schema, views.view.media_entity_browser:display.default.display_options.fields.media_bulk_form.selected_actions missing schema

That's because the view in -dev uses media_bulk_form from media_entity

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new create_a_new_branch-2906068-9.patch4.2 KB

New patch attempt.

sam152’s picture

sam152 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: create_a_new_branch-2906068-9.patch, failed testing. View results

jsheffers’s picture

jsheffers commented

Patch in #9 seems to work for me. I was able to get it installed on 8.4, add/remove multiple media entities. All of the changes to the entity browser seem to function properly as well.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.2906068.txt2.14 KB
new meb-2906068.patch4.98 KB

This passes locally

Status: Needs review » Needs work

The last submitted patch, 13: meb-2906068.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Committed this to 8.x-2.x

Will create an alpha

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.