I filled out password constraint form.. chose 3 uppercase and 2 lowercase characters. What's not obvious in the UI when adding a password is that the 3 uppercase characters can't be the same character. Policy status message says "Fail - Password must contain at 3 uppercase characters" and "Fail - Password must contain at least 2 lowercase characters". Seems like the status message should contain the word distinct or unique to be more clear.

CommentFileSizeAuthor
#11 password_policy_2894929.png69.46 KBjessicacs
#7 password_policy-updated_message.png86.58 KBbaikho
#6 interdiff_1-6.txt4.13 KBbaikho
#6 password_policy-password_character_plugin_corrected_message-2894929-6.patch5.59 KBbaikho
#2 issue-2894929-change_message-1.patch1.58 KBjayvolk

Issue fork password_policy-2894929

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jayvolk created an issue. See original summary.

jayvolk’s picture

jayvolk CreditAttribution: jayvolk as a volunteer and commented
Status: Active » Needs review
FileSize
issue-2894929-change_message-1.patch1.58 KB

patch for review

daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Status: Needs review » Reviewed & tested by the community

Re-queued the test and everything passed. The code here looks good and the text in the patch provides more clarity for the policy.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Status: Reviewed & tested by the community » Needs work

Should also be clarified for numeric and special characters.

Thanks for the issue and patch.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Category: Feature request » Bug report

I think this could be considered a bug.

baikho’s picture

baikho
Primary language Dutch
CreditAttribution: baikho as a volunteer and at Access commented
Status: Needs work » Needs review
FileSize
password_policy-password_character_plugin_corrected_message-2894929-6.patch5.59 KB
interdiff_1-6.txt4.13 KB

Same here, 1 of our clients has also highlighted this issue.

See attached patch with addressed change on comment #4 including plugin summary and the test updates.

baikho’s picture

baikho
Primary language Dutch
CreditAttribution: baikho as a volunteer and at Access commented
Issue summary: View changes
FileSize
password_policy-updated_message.png86.58 KB

hmendes made their first commit to this issue’s fork.

hmendes opened merge request !13

hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented

Re-rolling patch from #6 as a MR.

jessicacs’s picture

jessicacs CreditAttribution: jessicacs at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
password_policy_2894929.png69.46 KB

I tested issue from MR and it worked for me.

paulocs made their first commit to this issue’s fork.

  • paulocs committed 103a2c2 on 8.x-3.x authored by hmendes 
    Issue #2894929 by baikho, jayvolk, paulocs: Instructions unclear for...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.