CommentFileSizeAuthor
#10 2890279-10.diff333 bytesTommyChris
#6 jquery_patch_for_cookies.patch2.09 KBNicasso
#5 jquery_cookie_usage.patch2.61 KBNicasso
#2 eu_cookie_compliance-2890279-8.10-b7.patch922 bytesRobinTimman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobinTimman created an issue. See original summary.

RobinTimman’s picture

RobinTimman CreditAttribution: RobinTimman commented
FileSize
eu_cookie_compliance-2890279-8.10-b7.patch922 bytes
svenryen’s picture

svenryen CreditAttribution: svenryen commented

Drupal comes with support for $.cookie() which we're now using in the 7.x branch. I recommend that 8.x is updated as well.

boazpoolman’s picture

boazpoolman CreditAttribution: boazpoolman as a volunteer commented
Issue summary: View changes

Great patch!

Nicasso’s picture

Nicasso CreditAttribution: Nicasso commented
FileSize
jquery_cookie_usage.patch2.61 KB

I have a created a patch that uses $_cookie().

Nicasso’s picture

Nicasso CreditAttribution: Nicasso at Unc Inc commented
FileSize
jquery_patch_for_cookies.patch2.09 KB

This one should apply correctly.

Martijn Houtman’s picture

Martijn Houtman CreditAttribution: Martijn Houtman commented

Patch works for me!

  • svenryen committed 1ac98b4 on 8.x-1.x authored by Nicasso 
    Issue #2890279 by Nicasso, RobinTimman: Cookie not saving cause of wrong...
svenryen’s picture

svenryen CreditAttribution: svenryen commented
Status: Patch (to be ported) » Fixed

Thanks for the patch, Nicasso. I committed it now.

TommyChris’s picture

TommyChris
Primary language Hungarian
Location Budapest
CreditAttribution: TommyChris commented
FileSize
2890279-10.diff333 bytes

I think this patch needs another modification, to add library dependency. Without it, the module don't worked for me.
Patch attached.

eu_cookie_compliance:
  version: 1.0
  js:
    js/eu_cookie_compliance.js: {}
  css:
    state:
      css/eu_cookie_compliance.css: {}
  dependencies:
    - core/jquery
    - core/drupal
    - core/drupalSettings
    - core/jquery.once
+    - core/jquery.cookie

  • svenryen committed c363bd8 on 8.x-1.x authored by TommyChris 
    Issue #2890279 by Nicasso, RobinTimman, TommyChris, svenryen: Cookie not...
svenryen’s picture

svenryen CreditAttribution: svenryen commented

Thanks, TommyChris!

svenryen’s picture

svenryen CreditAttribution: svenryen commented
Status: Fixed » Closed (fixed)