Revision locking was added to FPP a while back to support editorial workflows. It's enabled by default on new sites, but not on existing sites. We should enable it on existing sites because (1) it's a great feature, and (2) it doesn't makes sense that Panopoly sites before/after the change would act so fundamentally different - it complicates support for no real gain.

However, there were also some fixes to the process of updating existing sites in FPP 1.11, so we also need to update that!

I read through the diff between 1.10 and 1.11 and it all looks harmless, but we'll need to do some testing.

CommentFileSizeAuthor
#5 interdiff-4-5.txt558 bytescboyden
#5 panopoly_core-fpp-v111-2875842-5.patch2.43 KBcboyden
#4 panopoly_core-fpp-v111-2875842-4.patch2.25 KBdsnopek
#3 panopoly_core-fpp-v111-2875842-3.patch2.26 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Er, hrm. I'm a little less confident about this given this bug:

#2820177: Revision ID breaks translation workflow

Maybe we could not update on sites that use entity_translation?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
panopoly_core-fpp-v111-2875842-3.patch2.26 KB

Here's a patch for testing!

EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/232599817

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
panopoly_core-fpp-v111-2875842-4.patch2.25 KB

Oops! Some copy-paste errors in there. Let's try this patch instead

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/232884039

cboyden’s picture

cboyden CreditAttribution: cboyden commented
Related issues: +#2826205: Broken links for Fieldable Panels Panes in admin menu after update
FileSize
panopoly_core-fpp-v111-2875842-5.patch2.43 KB
interdiff-4-5.txt558 bytes

I'm testing this locally and on a child distribution. There's a serious problem in the admin links for FPP, see #2826205: Broken links for Fieldable Panels Panes in admin menu after update. The patch in #39 of that issue seems to solve the problem. I've attached an updated patch to add it to the makefile.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Thanks!

Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/234124015

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Here's a new Travis build after some attempts to fix the tests:

https://travis-ci.org/panopoly/panopoly/builds/235003891

  • dsnopek committed c563db8 on 7.x-1.x 
    Update Panopoly Core for Issue #2875842 by dsnopek, cboyden: Update to...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Fixed

Travis tests finally came back good. My manual testing looked good. So.. committed! Thanks!

  • dsnopek committed c563db8 on 8.x-2.x 
    Update Panopoly Core for Issue #2875842 by dsnopek, cboyden: Update to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.