After updating to 7.x-1.11, the links to FPP pages in the admin menu do not work. Specifically, the urls for these pages are broken:
- admin/structure/fieldable-panels-panes
- admin/structure/fieldable-panels-panes/add
- admin/structure/fieldable-panels-panes/settings
If I manually create urls to my custom panes, those work. Such as: admin/structure/fieldable-panels-panes/image_pane where the image_pane is my custom FPP.
In addition to the links not working, I am getting these notices all over the site:
Unable to load the "" Fieldable Panels Pane type.
Unable to load the panels_pane Fieldable Panels Pane type.
Cache clears and cron runs and usual suspects haven't helped with any of these oddities.
I'm also using Media Pane 7.x-1.1 and I can get to that page just fine from manually entering the url like I do for my custom FPPs: admin/structure/fieldable-panels-panes/media_pane.
Comment | File | Size | Author |
---|---|---|---|
#39 | fieldable_panels_panes-n2826205-39.patch | 627 bytes | DamienMcKenna |
| |||
#36 | fieldable_panels_panes-n2826205-36.patch | 628 bytes | DamienMcKenna |
| |||
#32 | fieldable_panels_panes-n2826205-32.patch | 506 bytes | wilei |
| |||
#31 | fieldable_panels_panes-n2826205-31.patch | 503 bytes | Postovan Dumitru |
| |||
#21 | fieldable_panels_panes-n2826205-21.patch | 859 bytes | ron_s |
|
Comments
Comment #2
dat deaf drupaler CreditAttribution: dat deaf drupaler as a volunteer commentedSame here using 7.51 and 7.x-1.11... rolling back to 7.x-1.10
Comment #3
DamienMcKenna@dat deaf drupaler: Are you using Media Pane too?
Comment #4
dat deaf drupaler CreditAttribution: dat deaf drupaler as a volunteer commentedNo @damienmckenna, I reverted back to 7.x-1.10 and was able to regain access to FPP settings pages.
Comment #5
DamienMcKennaThe three paths listed come from different locations and have different permissions:
Are you sure that the roles had these permissions?
Comment #6
potassiumchloride CreditAttribution: potassiumchloride commentedYes, I'm the site admin and I have "administer fieldable panels panes" permission, and I couldn't get to those pages.
Comment #7
dat deaf drupaler CreditAttribution: dat deaf drupaler as a volunteer commentedI'm site admin as well and with all administering FPP permissions enabled, I can access all three settings page using 7.x-1.10 version.
Just tried again updating to 7.x-1.11 and clearing all caches, all these three pages crashes with "ERR_TOO_MANY_REDIRECTS". Nothing shows up in watchdog however I got bunches of "Unable to load the "" Fieldable Panels Pane type." in information green dialogue. Re-verified all permissions are enabled.
Comment #8
DamienMcKennaWell fudge :-(
Could you please install the Devel module, load this page and tell me what it says for 'access_callback' and 'access_arguments': devel/menu/item?path=admin/structure/fieldable-panels-panes
Comment #9
ron_s CreditAttribution: ron_s commentedaccess_callback = fieldable_panels_panes_access_callback
access_arguments = a:2:{i:0;s:21:"fieldable_panels_pane";i:1;s:4:"list";}
I'm actually able to access the URLs referenced in the first post... I'm getting the "Unable to load the "view" Fieldable Panels Pane type" errors when trying to access the view, edit, or delete links for any fieldable panel pane. This is what I get when running the menu path through devel:
access_callback = fieldable_panels_panes_access
access_arguments = a:2:{i:0;s:6:"update";i:1;i:4;}
The problem I'm seeing is the
$type
passed in tofieldable_panels_pane_type_load
is "view" instead of the fieldable panel pane name. I'm guessing one of the access arguments has gotten shifted and is passing in "view" rather than "%fieldable_panels_panes".Comment #10
ron_s CreditAttribution: ron_s commentedAlso I can confirm that rolling back to 7.x-1.10 fixes the issue of not being able to access the view, edit, and delete pages.
Comment #11
ron_s CreditAttribution: ron_s commentedOk, I think I see the issue. Three menu paths were changed between 7.x-1.10 and 7.x-1.11. For each of these three, "manage" was removed from the path:
From this:
To this:
If I comment out the the first one
admin/structure/fieldable-panels-panes/%fieldable_panels_pane_type
, I'm able to view/edit/delete existing fieldable panel panes.The issue is that viewing, editing, and deleting fieldable panel panes matches the
admin/structure/fieldable-panels-panes/%fieldable_panels_pane_type
menu path. The code is run first, throwing an error. There is no problem with the other two, because fieldable panel pane URLs don't have "add" or "list" in them.What was the reason for removing "manage" from the menu paths?
Comment #12
ron_s CreditAttribution: ron_s commentedReferencing the issue where the paths were changed.
Comment #13
ron_s CreditAttribution: ron_s commentedI've found a possible fix.
By adding a
'weight'
to theadmin/structure/fieldable-panels-panes/view/%fieldable_panels_panes
legacy path of-11
, it ensures that it occurs beforeadmin/structure/fieldable-panels-panes/%fieldable_panels_pane_type
. This avoids the error.I'll create a patch if this is an acceptable solution, thanks.
Comment #14
DamienMcKenna@ron_s: That's a good idea, and it would explain why such a simple thing would cause such a major problem. How about we add a weight to 'admin/structure/fieldable-panels-panes/%fieldable_panels_pane_type' so it's loaded after the others?
Comment #15
DamienMcKennaSo, basically this.
Comment #16
ron_s CreditAttribution: ron_s commentedActually, I tested that approach first and it didn't work. There is some conflict that causes a higher weight on
admin/structure/fieldable-panels-panes/%fieldable_panels_pane_type
to still act in the same way. I even tried'weight' => 100
and still no difference.The only way I was able to get it to work is to put a lower weight on
admin/structure/fieldable-panels-panes/view/%fieldable_panels_panes
. Maybe because/view
and/edit
have weights on them already?Comment #17
ron_s CreditAttribution: ron_s commentedOk, this is bizarre... I just tried some other tests with weights, then reverted back to the setup that I said worked, and it's no longer working. Cleared cache multiple items and still not able to access.
Comment #18
DamienMcKennaIt shouldn't be 'admin/structure/fieldable-panels-panes/view/%fieldable_panels_panes' that's causing the problem, it'd be 'admin/structure/fieldable-panels-panes', right?
Comment #19
DamienMcKennaMaybe this?
Comment #20
DamienMcKenna(yes, I'm throwing things at the wall hoping that something might fix it)
Comment #21
ron_s CreditAttribution: ron_s commentedRe: #18, yes you're right it should be, but setting a higher weight wasn't working. After clearing my cache several times and running several tests, there is only one way I can get it to work correctly: comment out
admin/structure/fieldable-panels-panes/%fieldable_panels_pane_type
entirely.In every other situation, regardless of the weights (and also testing your patch), the first value for
$type
infieldable_panels_pane_type_load
is 'view', and every other time it is the bundle. 'view' is not bundle, it is thearray(3)
value of the path.Is the load process (
fieldable_panels_pane_type_load
) ignoring weights? I was able to solve the problem by adding anelseif
... not saying this is a good solution, but it does work. See attached.Comment #22
maxplus CreditAttribution: maxplus commentedHi,
I also have the same problem after upgrading from 7.x-1.10 to 7.x-1.11.
When using the patch from #21 my admin links are working again, thanks!
Comment #23
PolPatch from #21 doesn't solve the problem here. Downgrading to 1.10.
Comment #24
ron_s CreditAttribution: ron_s commented@Pol, are you getting any error messages? Also just to clarify, which paths are you unable to access? I'm wondering if this is two separate issues.
Comment #25
Postovan Dumitru CreditAttribution: Postovan Dumitru commentedThe patch at #21 doesn't work for me either. Unfortunately, I can't access the logs at the moment, will post some updates as soon as I get to set up a local environment.
Just to be precise, none of the paths from the admin menu are working for me.
However, I seem to be able to access the panes directly, by entering
/admin/structure/fieldable-panels-panes/pane_machine_name.
Comment #26
ron_s CreditAttribution: ron_s commented@Postovan Dumitru, just to confirm that you cleared your cache a couple of times before trying? System menus have to be rebuilt for the links to work.
Comment #27
ArrowPatch in #21 fixes the issue for me.
Comment #28
Postovan Dumitru CreditAttribution: Postovan Dumitru commented@ron_s, thanks for your concern, it seems I'm getting an empty $type value, not the "view".
Unable to load the "" Fieldable Panels Pane type.
I will work on my personal issue as soon as I get to work and post here.
Note: Yes, I have cleared my cache a dozen of times with not luck.
Comment #29
Postovan Dumitru CreditAttribution: Postovan Dumitru at FFW commentedAdding a check for lack of a value did the trick for me (using the code from the patch).
Could someone include this and check? If not, I will attach the patch tomorrow. Cheers!
Comment #30
ron_s CreditAttribution: ron_s commented@Postovan Dumitru, once you mentioned your error message in #28, I wondered if testing for empty value might work. Although wondering if it might be more comprehensive to actually test for an empty value?
Also to the point made in #21, I'm still not sure this is the best solution... it does work, but the more fundamental problem (and I could be wrong) is it seems as though
fieldable_panels_pane_type_load
ignores menu weights.Comment #31
Postovan Dumitru CreditAttribution: Postovan Dumitru at FFW commentedThis one includes the empty value check.
@ron_s, you're absolutely right, this is not the fix we're looking for, but it's a temporary one, till someone figures out how to patch this up correctly.
I am going to see this through as soon as I get some spare time.
Comment #32
wilei CreditAttribution: wilei commentedWe encountered this problem with our use case of FPP, and I did some deepdiving to this problem.
Patch provided in #31 works but causes notices from _menu_translate(), "Notice: Undefined offset: 4 in function _menu_translate()".
So I changed return value from empty string '' to FALSE and now it works, without notices.
Comment #33
ec-adam CreditAttribution: ec-adam commented#32 worked great for me!
Comment #34
PolPatch #32 fixed the problem indeed.
Thanks!
Comment #35
arosboro CreditAttribution: arosboro commentedI'm confirming #32 works as others have noted above.
Comment #36
DamienMcKennaSo does this work too?
Comment #38
ron_s CreditAttribution: ron_s commentedComment in patch should be modified. It's still the same text I had in the original. Change from this:
To this:
Haven't tested the patch yet, but it makes sense to me.
Comment #39
DamienMcKennaGood catch, thanks. Corrected the comment.
Comment #40
DamienMcKennaCould someone who's experiencing this problem please let me know what arg(0) through maybe 5 or 6 are?
Comment #42
DamienMcKennaThe error is some sort of weird drupalci thing.
Comment #43
DamienMcKennaI opened an issue for the testbot errors: #2837319: Tests failing for Fieldable Panels Panes because of file permission errors
Comment #44
DamienMcKennaThere's an existing issue for D7 tests: #2837015: CI problem with permission when testing 7.x patches
Comment #45
kmontyPatch #39 worked for me.
Comment #46
DamienMcKennaBumping this request:
Comment #47
Nitebreed@DamienMcKenna, this is the result of arg() when using fieldable_panels_pane_type_load():
[5] can be anything like 'view', 'edit', or in my case 'translate'.
I can also confirm the latest patch works for me.
Comment #48
Rudi Teschner CreditAttribution: Rudi Teschner commentedEven with the patch in #39 I still have the issue that that the fieldable panels panes categories not listed in the admin menu.
I use the module 'admin source' to provide some custom lightweight menus to some roles and links to fpp categories that I manually add to these menus are also effected:
admin/structure/fieldable-panels-panes/fpp_titles_pane
admin/structure/fieldable-panels-panes/fpp_titles_pane/list.
arg():
Array
{
[0] => admin
[1] => structure
[2] => fieldable-panels-panes
[3] => fpp_titles_pane
[4] => list
}
edit:
Links like admin/structure/fieldable-panels-panes/view/34/edit work properly in the admin menu though, even without the patch.
Comment #49
DamienMcKennaOut of interest could you please test #2848997: WSOD on "list" page for FPP types to see if that solves the problem? Thanks.
Comment #50
Rudi Teschner CreditAttribution: Rudi Teschner commented@DamienMcKenna The patch in the other issue does not solve the problem for me, the behaviour is still the same.
Comment #51
vkakani CreditAttribution: vkakani commentedWe are noticing the same issue as well, as soon we have updated to Version: 7.x-1.11 .
None of the Fieldable Panels Panes admin links work. It's happening on D7.41 as well as D7.54 versions.
Solution : #39 patch resolves the issue
Comment #52
ron_s CreditAttribution: ron_s commented@DamienMcKenna, patch #39 works for us when viewing/editing fieldable panels panes or when viewing FPP admin pages:
Comment #53
Bram Esposito CreditAttribution: Bram Esposito as a volunteer commentedusing Media Pane. Patch #39 works for me
Comment #54
dan.munn CreditAttribution: dan.munn at Unipro Ltd commentedPatch #39 works for me too.
Comment #55
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedJust driving by here =)
Although the comment is technically correct, it doesn't explain why you want to return false when the if statement is true, can we think of something else that explains the reasoning to someone reading the code?
Comment #56
wylbur CreditAttribution: wylbur at Electric Citizen commentedThe patch in #39 worked for us. We were not able to load the FPP admin view, and after the patch, all FPP's were accessible.
We are not using the media_pane module.
Comment #57
langelhc CreditAttribution: langelhc commentedSame here the patch #39 worked for me. I updated from 7.x-1.7 to 7.x-1.11. I was not able to load the FPP admin pages:
- admin/structure/fieldable-panels-panes
- admin/structure/fieldable-panels-panes/add
- admin/structure/fieldable-panels-panes/settings
Comment #58
smaz+1 for the patch in #39 resolving the issue for me too. I was experiencing a redirect loop when trying to access the /admin/structure/fieldable-panels-panes path.
Comment #60
DamienMcKennaCommitted. Thank you.
FYI I updated the comment to the following: