Problem/Motivation

A follow-up to #2864037: [META] Update core PHP dependencies. See https://github.com/zendframework/zend-diactoros/releases

Proposed resolution

Update the library

Remaining tasks

  • Patch
  • Review
  • Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#10 2874817-10.patch506 bytesprestonso
#3 update-2874817-3.patch2.14 KBjibran
#2 update-2874817-2.patch2.14 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Active » Needs review
FileSize
update-2874817-2.patch2.14 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
FileSize
update-2874817-3.patch2.14 KB

New patch after #2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Needs review » Reviewed & tested by the community

I think we have enough test coverage around the Zend related things to catch any problems that this may cause. Release history from 1.3.10 to 1.4.0 also looks pretty tame.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: update-2874817-3.patch, failed testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented
Status: Needs work » Reviewed & tested by the community

Known random fail.

  • catch committed 435f6b7 on 8.4.x 
    Issue #2874817 by jibran, mpdonadio: Update zendframework/zend-diactoros...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +8.4.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

prestonso’s picture

prestonso CreditAttribution: prestonso as a volunteer commented
FileSize
2874817-10.patch506 bytes

While this commit updated composer.lock, it didn't update the corresponding entry in composer.json, where zendframework/zend-diactoros is still listed as ^1.1. Luckily, the version discrepancy doesn't actually cause any issues, since composer.lock is under version control, and even when solely relying on composer.json, Composer fetches the latest version.

Nonetheless, because composer.json is intended to be an authoritative manifest of dependencies, this should be addressed. This issue should probably be reopened to take this into account. This patch resolves the version discrepancy between the two files.

prestonso’s picture

prestonso CreditAttribution: prestonso as a volunteer commented

I've created a follow-up issue to reflect the discrepancies between composer.json and composer.lock: #2899106: Ensure all minor versions in composer.json match composer.lock. A patch is available there as well.