Problem/Motivation
Various classes in the video_embed_field module place their constructor at the bottom of the class, or inbetween methods. Core classes all place their constructor (and setter injection) before the class's methods. And that is where I was looking for them.
Proposed resolution
To prevent unneeded searching by other developers, I suggest to follow core's pattern.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | video_embed_field-constructor-dx-2867433-4.patch | 24.77 KB | sutharsan |
| #2 | video_embed_field-constructor-dx-2867433-2.patch | 24.38 KB | sutharsan |
Comments
Comment #2
sutharsan commentedComment #4
sutharsan commentedOne constructor was deleted instead of moved...
Comment #5
sam152 commentedI used to like getting them out of the way, but I agree, we should follow what core does.
Comment #6
sam152 commented