Problem/Motivation

Various classes in the video_embed_field module place their constructor at the bottom of the class, or inbetween methods. Core classes all place their constructor (and setter injection) before the class's methods. And that is where I was looking for them.

Proposed resolution

To prevent unneeded searching by other developers, I suggest to follow core's pattern.

Comments

Sutharsan created an issue. See original summary.

sutharsan’s picture

Status: Active » Needs review
StatusFileSize
new24.38 KB

Status: Needs review » Needs work

The last submitted patch, 2: video_embed_field-constructor-dx-2867433-2.patch, failed testing.

sutharsan’s picture

Status: Needs work » Needs review
StatusFileSize
new24.77 KB

One constructor was deleted instead of moved...

sam152’s picture

I used to like getting them out of the way, but I agree, we should follow what core does.

sam152’s picture

Status: Needs review » Fixed

  • Sam152 committed 9eff631 on 8.x-1.x authored by Sutharsan
    Issue #2867433 by Sutharsan: Improve DX by placing the constructor on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.