Resolving this @todo:

  /**
   * {@inheritdoc}
   */
  public function isVisible() {
    // @todo Check that the order contains at least one shippable entity.
    return $this->order->hasField('shipments');
  }
CommentFileSizeAuthor
#8 commerce_shipping-hide-shipping-info-pane-2854495-8.patch573 bytesshabana.navas
#5 commerce_shipping-hide-shipping-info-pane-2854495-5.patch1.11 KBjsacksick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

iajay’s picture

iajay CreditAttribution: iajay commented

Is this possible currently?

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

No, hence the open issue.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at Valuebound commented
Status: Active » Needs review

@Bojanz Need a direction,

  public function isVisible() {
    // @todo Check that the order contains at least one shippable entity.
    $order_id = $this->order->id();
    $order = Order::load($order_id)->getItems()[0]->getPurchasedEntity();
    return $this->order->hasField('shipments');
  }

Trying to check the product variation is "shippable" or not. Don't know whether it is a right direction or not. Any way struck on loading respective traits (PurchasableEntityShippable) on the product variant.:(

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
FileSize
commerce_shipping-hide-shipping-info-pane-2854495-5.patch1.11 KB

  • bojanz committed d1b8889 on 8.x-2.x authored by jsacksick 
    Issue #2854495 by jsacksick, bojanz, rakesh.gectcr: Hide the...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Thanks, jsacksick!

shabana.navas’s picture

shabana.navas CreditAttribution: shabana.navas commented
Status: Fixed » Needs work
FileSize
commerce_shipping-hide-shipping-info-pane-2854495-8.patch573 bytes

I believe there is a little mistake in this patch. If you look, it is returning FALSE by default, so instead of:

if (!$this->order->hasField('shipments')) {
  return TRUE;
}

it SHOULD be:

if ($this->order->hasField('shipments')) {
  return TRUE;
}

because we're doing a check for "if shipment should be visible" right. New patch has been added.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed

Looks like you misunderstood the code.
From your patch:

    * {@inheritdoc}
    */
   public function isVisible() {
-    if (!$this->order->hasField('shipments')) {
+    if ($this->order->hasField('shipments')) {
       return FALSE;
     }

The current code hides the pane if the order has no "shipments" field (== isn't shippable).
Your change hides the pane if the order has a shipments field (== is shippable). That doesn't make sense :)

shabana.navas’s picture

shabana.navas CreditAttribution: shabana.navas commented

My apologies, yeah, I guess, I did misunderstand the check.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.