Add test coverage

I was asked to help here. Did anybody yet defined the scenarios to test?

Thanks for helping with this Christian.

The top priority is fixing the existing tests. Here are the test results outlining the errors occurring, https://www.drupal.org/pift-ci-job/2361839

If you have suggestions on additional test coverage that would be helpful to have we're open to that. Here are some ideas in the meantime,

• Bypass Maxlength limit permission applies to the correct roles.
• Maxlength limit method works as intended.
• Previously set Maxlength limit value persists.

I had some time to look at it and wanted to see if I could get the existing tests running. Unfortunately, I'm not seeing a means of running DrupalCI on the merge request I just created, so I converted my work in the issue fork into a patch.

The "Max Length Summary" label has been changed to "Maximum Length Summary." Updated the test to reflect that.

Take 2, I somehow truncated the end of that prior patch.

#10 failed as well, this time with a slightly different error message:

1) Drupal\Tests\maxlength\FunctionalJavascript\MaxlengthCustomWidgetTest::testMaxlengthCustomWidgetSupported
WebDriver\Exception\UnknownError: element not interactable

Trying one more time here -- The documentation for TraversableElement::findField states that it accepts the name attribute as well, so I'm giving that a go. After this, I'll accept that I'm past my depth on figuring out testing with the time I have available at present.

Failed again -- Clayton, I suggest we disable unit testing for now on the 2.0.x branch and see if Christian or someone else more knowledgeable w/ DrupalCI can take this up.

Assigning to joevagyok to take the lead on this.

Hi @joevagyok,

Thanks for all the great work on this issue. The tests from my vantage point look as expected, but we should have Steven or Jeff review that as well.

The validation that the maxlength number be positive works. However, now it is not possible to remove a maxlength value altogether. The final expected behavior should be that if the maximum length field is blank, no maxlength setting is applied at all.

Also, for enforcing the summary maxlength, it should be possible to set a Maxlength for the summary, but not the associated long text field.

Thank you for the review @cedewey. In my last commit, I addressed your remarks with their corresponding tests.

Thanks @joevagyok, both of the issues I flagged are resolved. Assigning to @hipp2bsquare to do a technical review of the test coverage and fixes.

Maintainers have reviewed and approved this substantial contribution. Thank you, joevagyok!

Thank you.