The settings are missing the configuration schema, needed for deployments or in tests. Patch coming up in a few minutes.

CommentFileSizeAuthor
#2 2790175-2.patch836 bytesswentel

Comments

swentel created an issue. See original summary.

swentel’s picture

StatusFileSize
new836 bytes

This at least makes my local tests pass. Been pondering whether the integers should be booleans though, but it's fine for now.

swentel’s picture

Status: Active » Needs review

Needs review of course.

masipila’s picture

Status: Needs review » Needs work

Could you open up the backgrounds for this a bit? I'm happy to include the schema but I currently don't have enough time to educate myself on this topic so help is appreciated to speed up this ending up to a release.

1) So for what purposes exactly do we need this and could you please give a pointer to relevant documentation?

2) The labels in your patch do not match to the labels we currently have on the settings form. Please update the patch to be consistent with them.

Cheers,
Markus

swentel’s picture

All relevant information is at https://www.drupal.org/node/1905070

masipila’s picture

Hi,

thanks for the link! I applied the patch and checked the schema with Config Inspector module. According to the inspector, the schema seems to be technically ok.

Could you please update the labels of the patch so that they match to the actual labels of the settings form?

Cheers,
Markus

masipila’s picture

Assigned: Unassigned » masipila

Hi again,

I just decided that 'm going to release 8.x-3.0-beta4 later today. I'll update the labels myself and include this in beta4. Just wanted to let you know that I'm working on this so that we don't do double work.

Thanks for your contribution!

Cheers,
Markus

  • masipila committed 1250b46 on 8.x-3.x authored by swentel
    Issue #2790175 by swentel: Missing configuration schema
    
masipila’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.