KernelTestBase is about to die #2734663: Update deprecation message for old KernelTestBase in simpletest. Let's convert Kernel tests to KernelTestBaseNG

CommentFileSizeAuthor
#9 covert_kernel_tests_to-2734835-9.patch5.76 KBsam152
#9 interdiff.txt1.24 KBsam152
#6 Screen Shot 2016-06-16 at 2.51.52 PM.png210.15 KBsam152
#5 covert_kernel_tests_to-2734835-5.patch4.96 KBsam152
#5 interdiff.txt1 KBsam152
#4 covert_kernel_tests_to-2734835-4.patch4.71 KBsam152
#4 interdiff.txt3.12 KBsam152
#2 covert_kernel_tests_to-2734835-2.patch2.08 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new covert_kernel_tests_to-2734835-2.patch2.08 KB

Status: Needs review » Needs work

The last submitted patch, 2: covert_kernel_tests_to-2734835-2.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.12 KB
new covert_kernel_tests_to-2734835-4.patch4.71 KB
sam152’s picture

sam152 commented
StatusFileSize
new interdiff.txt1 KB
new covert_kernel_tests_to-2734835-5.patch4.96 KB
sam152’s picture

sam152 commented
StatusFileSize
new Screen Shot 2016-06-16 at 2.51.52 PM.png210.15 KB

The same amount of tests were being run in HEAD, they were just counted differently, see screenshot. I don't think the tests enabled in #5 have run on the bot before, but they are green locally at least.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Thanks, will commit this later.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

LGTM. Thanks for looking at it.

sam152’s picture

sam152 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff.txt1.24 KB
new covert_kernel_tests_to-2734835-9.patch5.76 KB

Trying to get the unit test to run...

sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community

That did it. As long as there are no objections with a directory change, setting back to RTBC.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Covert Kernel tests to KernelTestBaseNG » Convert Kernel tests to KernelTestBaseNG
benjy’s picture

benjy commented
Status: Reviewed & tested by the community » Fixed

Thanks.

  • benjy committed 92f735c on 8.x-1.x authored by Sam152 
    Issue #2734835 by Sam152, jibran: Convert Kernel tests to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.