When using the WYSIWYG option I get escaped output, I can look into this now also but I'm reporting it here to follow etc.

This is what I get when viewing the node (in edit mode I can see the video thumb in the editor):

{"preview_thumbnail":"http://drupal-8-2-x-dev:8888/sites/default/files/styles/video_embed_wys…","video_url":"https://www.youtube.com/watch?v=8Zpi9V0_5tw","settings":{"responsive":1,"width":"854","height":"480","autoplay":0},"settings_summary":["Embedded Video (Responsive)."]}

CommentFileSizeAuthor
#58 test.patch12.04 KBsam152
#49 test.patch10.3 KBsam152
#46 test.patch700 bytessam152
#44 test.patch10.57 KBsam152
#43 test.patch11.05 KBsam152
#38 test.patch7.78 KBsam152
#34 test.patch7.96 KBsam152
#29 2716375-filter-order-29.patch7.82 KBsam152
#25 2716375-filter-order-25--test-only.patch6.86 KBsam152
#25 2716375-filter-order-25.patch6.86 KBsam152
#18 2716375-filter-order-18.patch5.62 KBsam152
#18 2716375-filter-order-18--test-only.patch3.92 KBsam152
#14 Screen Shot 2016-06-28 at 13.48.41.png37.04 KBkriboogh
#9 2716375-fix-for-no-wrappers-4.patch2.65 KBsam152
#4 2716375-test-case-4.patch1.67 KBsam152

Comments

Jeff Burnz created an issue. See original summary.

sam152’s picture

sam152 commented

I don't mind tracking it down either. Can you tell me:

  • Your text format settings. Do you allow paragraph tags?
  • Your editor settings.
  • Are you using the latest version? RC8 uses relative URLs for the thumbnail preview.
  • Do you definitely have the text filter AND the button enabled (there should be a validation check for this).
  • What text format are you using? Anything which strips paragraph tags isn't going to work.
sam152’s picture

sam152 commented

I was able to reproduce this by switching to 'Trimmed' or 'Summary or trimmed'.

sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new 2716375-test-case-4.patch1.67 KB

We could either figure out why the trimmed formatters remove paragraphs, or make the following test case pass.

Status: Needs review » Needs work

The last submitted patch, 4: 2716375-test-case-4.patch, failed testing.

The last submitted patch, 4: 2716375-test-case-4.patch, failed testing.

The last submitted patch, 4: 2716375-test-case-4.patch, failed testing.

The last submitted patch, 4: 2716375-test-case-4.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2716375-fix-for-no-wrappers-4.patch2.65 KB

And the fix.

sam152’s picture

sam152 commented

Let me know if the patch works for your use case.

sam152’s picture

sam152 commented
Status: Needs review » Fixed

  • Sam152 committed a842a01 on 8.x-1.x 
    Issue #2716375 by Sam152: Escaped output

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kriboogh’s picture

kriboogh commented
StatusFileSize
new Screen Shot 2016-06-28 at 13.48.41.png37.04 KB

I know this issue is closed, but I still had the escaped output. I also had an incorrect json encoding in the video_url parameter. It contained an actual "a href" tag. For anybody looking for a fix, the problem lies in the order of the text format filters.
Make sure that the video embed filter is ran before the the "Convert URLs into links" and that the "Limit allowed HTML tags and correct faulty HTML" is ran before the video embed filter.

Maybe this should be documented somewhere? or the weight of the filter should be default between and above the mentioned filters.

kriboogh’s picture

kriboogh commented
Component: Code » Documentation
Status: Closed (fixed) » Needs review
sam152’s picture

sam152 commented
Status: Needs review » Needs work

Thanks for providing some more detail. We should write a test and validation which ensures the weights are in the right order, to prevent anyone from having to track this down again.

sam152’s picture

sam152 commented
Title: Escaped output » Ensure WYSIWYG filters run in the correct order to avoid escaping
sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2716375-filter-order-18--test-only.patch3.92 KB
new 2716375-filter-order-18.patch5.62 KB

The last submitted patch, 18: 2716375-filter-order-18--test-only.patch, failed testing.

The last submitted patch, 18: 2716375-filter-order-18--test-only.patch, failed testing.

The last submitted patch, 18: 2716375-filter-order-18--test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 18: 2716375-filter-order-18.patch, failed testing.

The last submitted patch, 18: 2716375-filter-order-18.patch, failed testing.

The last submitted patch, 18: 2716375-filter-order-18.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2716375-filter-order-25.patch6.86 KB
new 2716375-filter-order-25--test-only.patch6.86 KB

The last submitted patch, 25: 2716375-filter-order-25.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 25: 2716375-filter-order-25--test-only.patch, failed testing.

The last submitted patch, 25: 2716375-filter-order-25--test-only.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2716375-filter-order-29.patch7.82 KB

Increased timeouts to reduce colorbox fails?

Status: Needs review » Needs work

The last submitted patch, 29: 2716375-filter-order-29.patch, failed testing.

The last submitted patch, 29: 2716375-filter-order-29.patch, failed testing.

The last submitted patch, 29: 2716375-filter-order-29.patch, failed testing.

The last submitted patch, 29: 2716375-filter-order-29.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new test.patch7.96 KB

Status: Needs review » Needs work

The last submitted patch, 34: test.patch, failed testing.

The last submitted patch, 34: test.patch, failed testing.

The last submitted patch, 34: test.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new test.patch7.78 KB

The last submitted patch, 34: test.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 38: test.patch, failed testing.

The last submitted patch, 38: test.patch, failed testing.

The last submitted patch, 38: test.patch, failed testing.

sam152’s picture

sam152 commented
StatusFileSize
new test.patch11.05 KB
sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new test.patch10.57 KB

Status: Needs review » Needs work

The last submitted patch, 44: test.patch, failed testing.

sam152’s picture

sam152 commented
StatusFileSize
new test.patch700 bytes
sam152’s picture

sam152 commented
Status: Needs work » Needs review

The last submitted patch, 44: test.patch, failed testing.

sam152’s picture

sam152 commented
StatusFileSize
new test.patch10.3 KB

The last submitted patch, 44: test.patch, failed testing.

The last submitted patch, 44: test.patch, failed testing.

The last submitted patch, 43: test.patch, failed testing.

The last submitted patch, 43: test.patch, failed testing.

The last submitted patch, 46: test.patch, failed testing.

The last submitted patch, 46: test.patch, failed testing.

The last submitted patch, 46: test.patch, failed testing.

The last submitted patch, 43: test.patch, failed testing.

sam152’s picture

sam152 commented
StatusFileSize
new test.patch12.04 KB

  • Sam152 committed 0021bb3 on 8.x-1.x 
    Issue #2716375 by Sam152, kriboogh: Ensure WYSIWYG filters run in the...
sam152’s picture

sam152 commented
Status: Needs review » Fixed

The last submitted patch, 18: 2716375-filter-order-18--test-only.patch, failed testing.

The last submitted patch, 18: 2716375-filter-order-18.patch, failed testing.

The last submitted patch, 25: 2716375-filter-order-25.patch, failed testing.

The last submitted patch, 25: 2716375-filter-order-25--test-only.patch, failed testing.

The last submitted patch, 43: test.patch, failed testing.

The last submitted patch, 46: test.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.