Integrate with the media_entity module.

Thank you for your work. This is very exciting!

1. +++ b/modules/video_embed_media/src/Plugin/MediaEntity/Type/VideoEmbedField.php
   @@ -0,0 +1,146 @@
   +
   +  /**
   +   * The function that is invoked during the insert of media bundles.
   +   *
   +   * @param $media_bundle_id
   +   */
   +  public static function createVideoEmbedField($media_bundle_id) {
   +    if (!$storage = FieldStorageConfig::loadByName('media', static::VIDEO_EMBED_FIELD_NAME)) {
   +      FieldStorageConfig::create([
   +        'field_name' => static::VIDEO_EMBED_FIELD_NAME,
   +        'entity_type' => 'media',
   +        'type' => 'video_embed_field',
   +      ])->save();
   +    }
   +    FieldConfig::create([
   +      'entity_type' => 'media',
   +      'field_name' => static::VIDEO_EMBED_FIELD_NAME,
   +      'label' => 'Video URL',
   +      'required' => TRUE,
   +      'bundle' => $media_bundle_id,
   +    ])->save();
   +    // Make the field visible on the form display.
   +    $form_display = entity_get_form_display('media', $media_bundle_id, 'default');
   +    $form_display->setComponent(static::VIDEO_EMBED_FIELD_NAME, [
   +      'type' => 'video_embed_field_textfield',
   +    ])->save();
   +  }
   

   Approach that media_entity takes is to make main field configurable. Instead of pre-creating it we allow site builder to decide how entity data model looks like and determine that through configuration.

2. +++ b/modules/video_embed_media/src/Plugin/MediaEntity/Type/VideoEmbedField.php
   @@ -0,0 +1,146 @@
   +  /**
   +   * {@inheritdoc}
   +   */
   +  public function providedFields() {
   +    return [
   +      'embed_code' => $this->t('Video Embed Code'),
   +    ];
   +  }
   

   If we'd be deprecating media_entity_embeddable_video I'd like list of provided fields to be equivalent. See https://github.com/drupal-media/media_entity_embeddable_video/blob/8.x-1...

3. +++ b/modules/video_embed_media/video_embed_media.info.yml
   @@ -0,0 +1,8 @@
   +name: Video Embed Media
   +type: module
   +description: 'Integrates embedded videos into the Drupal Media Entity module.'
   +package: Field types
   +core: 8.x
   +dependencies:
   +  - media_entity
   +  - video_embed_field
   

   This module essentially provides only Media type plugin. I don't see any reason why this couldn't live in VEF.

4. If we want to deprecate media_entity_embeddable_video we need to figure out how to handle sites that are using it. We could provide upgrade path or keep support for text/link fields. I am not strongly opinionated on that. The only thing that is important for me is that we don't leave current users behind.

In general I am in favour of merging the two modules. It will reduce fragmentation and make ecosystem more sustainable. The two most important things that I'd like to achieve before we do that is to handle existing sites and achieve feature parity. I am available on IRC if needed.

1. +++ b/modules/video_embed_media/src/Plugin/MediaEntity/Type/VideoEmbedField.php
   @@ -0,0 +1,200 @@
   +/**
   + * @file
   + * Contains \Drupal\video_embed_media\Plugin\MediaEntity\Type\VideoEmbedField.
   + */
   

   This @file blocks are not required any more. More a FYI than a blocker.

2. +++ b/modules/video_embed_media/src/UpgradeManager.php
   @@ -0,0 +1,83 @@
   +    $media_entities = $this->entityQuery->get('media')->condition('bundle', $bundle->id())->execute();
   +    foreach ($media_entities as $media_entity) {
   

   Number of items in this result set can be very large in general. I think it would be great idea to support batch processing to prevent timeouts and other problem.

   I am OK if we make this a follow-up.

3. +++ b/modules/video_embed_media/src/UpgradeManager.php
   @@ -0,0 +1,83 @@
   +    // Copy the existing media bundle field value to the new field value.
   +    $existing_url = $media_entity->{$type_configuration['source_field']}->getValue();
   +    $media_entity->{VideoEmbedField::VIDEO_EMBED_FIELD_DEFAULT_NAME} = $existing_url;
   +    $media_entity->save();
   

   While this will correctly migrate values stored in text fields it won't succeed with the ones stored in link fields (both types are supported in MEEV). I manually tested it and that also confirmed this issue.

I manually tested it and it works nicely.

Great job. Almost there. When we commit this it would make sense to release a new version on VEF. After that we can put a deprecation message on MEEV project page.

It would also make sense to update our guide at that point.

Looks good. Should we create follow-ups for batch migration and d8 guide update?

Great job. Added a message to MEEV project page. https://www.drupal.org/project/media_entity_embeddable_video

I inherited a site that had hundreds of media entities of the video type created with 'Media entity embeddable video 8.x-1.0-beta2'.
Installing the latest dev version of this module (Video Embed Field 8.x-1.5+4-dev (2017-Dec-01)) saved me a whole world of hurt.
Thank you very much.

Hi, I am trying to upgrade a drupal 8.9.20 system which heavily relies on the media_entity_embeddable_video module. I tried all the steps described here but the migration seems to srew up the database, so that all embedded videos disappear.
It seems like this is a two step pocess. First migration from media_entity_embeddable_video to VEF media entity 1.x/2.x and then migration to the core media module.
Does any of you have a hint what to do or where to look to solve this?