Comments

kevinquillen created an issue. See original summary.

hongpong’s picture

Status: Active » Needs review
StatusFileSize
new10.95 KB

I fixed the line wraps and updated some of the info. It still has some I think obsolete info about compass but at least hurts less to try to read. Should be RTBC for now.

I appreciate the efforts on all this and will try to post other patches as I can find them in 8.x-6.x, would like to build out more sites with this for sure.

hongpong’s picture

Issue summary: View changes
Issue tags: +bower, +npm, +Gulp
StatusFileSize
new14.18 KB
new10.48 KB

Okay now this has info for setting up npm and bower, dropping the old compass info. Also includes more clear info about things to start going on a subtheme. the STARTERKIT/readme.txt is also improved. Please take a look see, I think it is up to date to correspond with #2702271: Update Zurb Foundation to 6.2 and use our STARTER Gulp config in the base theme now.

samuel.mortenson’s picture

StatusFileSize
new13.99 KB

Looks good, but can you explain:

"This branch is still in active development. If you make a child theme, you may have to copy the foundation folder in /scss to the child theme to compile successfully."

Looking at STARTER/gulpfile.js, it looks like Foundation/Motion UI should be included directly from bower_components. I'm not sure what copying foundation to the scss directory would do.

Here's an updated patch which fixes a conflict (off canvas markup has changed) which stopped the last patch from applying to HEAD, but I'd still like to remove the text mentioned above if we can address that issue.

hongpong’s picture

StatusFileSize
new790 bytes
new13.87 KB

Yeah that was a problem I had with the version before all the gulp stuff got rolled in. I modified the readme to drop the statement in question. Here is the patch to that effect, based off #4 patch. [ my old problem was similar to #2693133: Change settings in subtheme ]

samuel.mortenson’s picture

Status: Needs review » Fixed

Done! Thanks for the clarification @HongPong

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.