When I tried to install this module for drupal 8 it give me following error
:

RuntimeException: Failed to start the session because headers have already been sent by "/var/www/html/drupal/drupal8/modules/visitors/src/EventSubscriber/KernelTerminateSubscriber.php" at line 189. in Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage->start() (line 144 of /var/www/html/drupal/drupal8/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php).

If you try to uninstall this module, it produces an error like so:

Drupal\Core\Config\ImmutableConfigException: Can not delete immutable configuration visitors.config. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->delete() (line 56 of /var/www/html/drupal/drupal8/core/lib/Drupal/Core/Config/ImmutableConfig.php)

Comments

vb_swapnil created an issue. See original summary.

Pierre.Vriens’s picture

Title: Module not working for drupal 8 » Make D8 release of this module work again
Category: Bug report » Task
Issue summary: View changes
Priority: Normal » Major

The 8.x-2.0 release of this module, from 2014, was created way before I became the new maintainer of this module. This specific release, which also dates from before the official release of D8, has stopped working.

Until that is fixed, I've changed the release status from "Recommended" to "Other".

Anybody interested in speeding up things to get it to work: appropriate patches welcome!

Pierre.Vriens’s picture

Title: Make D8 release of this module work again » Make D8 release of Visitors work again
omlx’s picture

This is what I modified to get the module uninstalled. in visitors.install file:

/**
 * Uninstall the module with database table and module settings.
 */
function visitors_uninstall() {
  drupal_uninstall_schema('visitors');

  /*\Drupal::config('visitors.config')->delete();*/
  \Drupal::configFactory()->getEditable('visitor.config')->delete();
}

/**
shreya shetty’s picture

Status: Needs work » Needs review
StatusFileSize
new377 bytes

i have provided the patch for the same

Pierre.Vriens’s picture

Merci (oeps: thank you!) @Shreya Shetty ! Would be nice if "somebody" would be able/willing to submit a similar patch for #2599042: Make D8 release of Visitors work again ... (which will probably take a few more lines of changes though ...).

a_anbarasan’s picture

unable to uninstall this module now,
eagerly waiting for this module ,bug fixed and supporting version D8..

rafuel92’s picture

StatusFileSize
new49.15 KB

Hello, first of all thanks for this module, i'm glad to inform you that i've performed an initial porting to Drupal 8.3.x, attached you can find a patch that makes this module work again, it generates statistical charts correctly now using jquery.jqplot library, i'm working also on visitors_geoip to provide geo stats and i'll release a separate patch in next days.
I suggest to create a new 8.x-3.0 dev version with this patch.

rafuel92’s picture

Hello, this is the release that fixes also visitors_geoip.module, now the module provides also stats about countries and cities.

rafuel92’s picture

New patch

rafuel92’s picture

StatusFileSize
new56.93 KB

That's the right patch with all the relevant changes, it includes :
visitors module and visitors_geoip module

leeksoup’s picture

Does Visitors module still have a project maintainer?
If so, can that person check / add this patch of @rafuel92?

If not, is it possible @rafuel92 will want to be added as a maintainer?

rafuel92’s picture

Hello @leeksoup, become maintainer of the D8 version for me is not a problem, i have also additional improvements to release.

rafuel92’s picture

Any good news? :)

rajeshreeputra’s picture

Any Good news for Visitors Module????

rafuel92’s picture

Yes @Rajeshreeputra, i've developed a patch that makes the module work again.
The patch includes :
visitors module and visitors_geoip module, i'm waiting to become maintainer of the D8 Version or for the patch that i've produced to be committed.

websiteworkspace’s picture

What is the expected timeframe for a working D8 version of this module?

rafuel92’s picture

Hello the patch at #11 that i've provided makes this module work again.

websiteworkspace’s picture

What is the expected timeframe for committing the noted patch to a dev or stable release of this module?

At present there hasn't been a new release, dev or stable, of this module since 7 June 2014.

rafuel92’s picture

I’ve posted the patch but actually i’m not the maintainer, so i can’t commit the patch on the repository because i don’t have the privileges.

dbjpanda’s picture

Status: Needs review » Needs work

I am getting error after applying the patch #11.

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Drupal\Core\Database\SchemaObjectDoesNotExistException</em>: Cannot add field visitors.visitors_continent_code: table doesn&#039;t exist. in <em class="placeholder">Drupal\Core\Database\Driver\mysql\Schema-&gt;addField()</em> (line <em class="placeholder">404</em> of <em class="placeholder">core/lib/Drupal/Core/Database/Driver/mysql/Schema.php</em>). <pre class="backtrace">db_add_field(&#039;visitors&#039;, &#039;visitors_continent_code&#039;, Array) (Line: 101)
visitors_geoip_install()
call_user_func_array(&#039;visitors_geoip_install&#039;, Array) (Line: 391)
Drupal\Core\Extension\ModuleHandler-&gt;invoke(&#039;visitors_geoip&#039;, &#039;install&#039;) (Line: 291)
Drupal\Core\Extension\ModuleInstaller-&gt;install(Array, 1) (Line: 83)
Drupal\Core\ProxyClass\Extension\ModuleInstaller-&gt;install(Array) (Line: 448)
Drupal\system\Form\ModulesListForm-&gt;submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter-&gt;executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter-&gt;doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder-&gt;processForm(&#039;system_modules&#039;, Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder-&gt;buildForm(&#039;system_modules&#039;, Object) (Line: 74)
Drupal\Core\Controller\FormController-&gt;getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}() (Line: 576)
Drupal\Core\Render\Renderer-&gt;executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber-&gt;Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 153)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache-&gt;pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel-&gt;handle(Object) (Line: 19)
</pre>The website encountered an unexpected error. Please try again later.<br /><em class="placeholder">Drupal\Core\Database\DatabaseExceptionWrapper</em>: SQLSTATE[42S02]: Base table or view not found: 1146 Table &#039;quickguide.qgm_visitors&#039; doesn&#039;t exist: INSERT INTO {visitors} (visitors_uid, visitors_ip, visitors_date_time, visitors_url, visitors_referer, visitors_path, visitors_title, visitors_user_agent, visitors_continent_code, visitors_country_code, visitors_country_code3, visitors_country_name, visitors_region, visitors_city, visitors_postal_code, visitors_latitude, visitors_longitude, visitors_dma_code, visitors_area_code) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12, :db_insert_placeholder_13, :db_insert_placeholder_14, :db_insert_placeholder_15, :db_insert_placeholder_16, :db_insert_placeholder_17, :db_insert_placeholder_18); Array
(
    [:db_insert_placeholder_0] =&gt; 1
    [:db_insert_placeholder_1] =&gt; 2130706433
    [:db_insert_placeholder_2] =&gt; 1515123126
    [:db_insert_placeholder_3] =&gt; http://quickguide.dd/drupal/admin/modules
    [:db_insert_placeholder_4] =&gt; http://quickguide.dd/drupal/admin/modules
    [:db_insert_placeholder_5] =&gt; /drupal/admin/modules
    [:db_insert_placeholder_6] =&gt; Extend
    [:db_insert_placeholder_7] =&gt; Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36
    [:db_insert_placeholder_8] =&gt; 
    [:db_insert_placeholder_9] =&gt; 
    [:db_insert_placeholder_10] =&gt; 
    [:db_insert_placeholder_11] =&gt; 
    [:db_insert_placeholder_12] =&gt; 
    [:db_insert_placeholder_13] =&gt; 
    [:db_insert_placeholder_14] =&gt; 
    [:db_insert_placeholder_15] =&gt; 0
    [:db_insert_placeholder_16] =&gt; 0
    [:db_insert_placeholder_17] =&gt; 0
    [:db_insert_placeholder_18] =&gt; 0
)
 in <em class="placeholder">Drupal\visitors\EventSubscriber\KernelTerminateSubscriber-&gt;onTerminate()</em> (line <em class="placeholder">77</em> of <em class="placeholder">modules/visitors/src/EventSubscriber/KernelTerminateSubscriber.php</em>). <pre class="backtrace">Drupal\visitors\EventSubscriber\KernelTerminateSubscriber-&gt;onTerminate(Object, &#039;kernel.terminate&#039;, Object) (Line: 108)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher-&gt;dispatch(&#039;kernel.terminate&#039;, Object) (Line: 88)
Symfony\Component\HttpKernel\HttpKernel-&gt;terminate(Object, Object) (Line: 32)
Stack\StackedHttpKernel-&gt;terminate(Object, Object) (Line: 635)
Drupal\Core\DrupalKernel-&gt;terminate(Object, Object) (Line: 22)
</pre>
rafuel92’s picture

StatusFileSize
new282.24 KB

Hello @dbjpanda, i suppose that you've already installed the visitors module and something went wrong during the installation phase.

You can try again on a fresh drupal 8 install (with a clean database) and enable the module, it will give the result available in the attached screenshot.

jurgenmo’s picture

I've applied patch #11, now I can get to the settings page (admin/config/system/visitors) and save the settings.
I see the block in the block lay-out list, but can't place the block. If i click on it notting happens.

cestmoi’s picture

@Pierre.Vriens

Would be nice if "somebody" would be able/willing to submit a similar patch for #2599042: Make D8 release of Visitors work again ... (which will probably take a few more lines of changes though ...).

@rafuel92 kindly submitted a patch months ago and yet no maintainer seems interested in saying a word about the fate of this port !

mmjvb’s picture

Don't know how this project uses the issue queue, but Status `Needs work` normally means it is not ready for committing to th code base. It means that something needs to be done first. After which it would go to `Needs review` and hopefully people try it out and confirm resolving the issue by setting to `RTBC`. That is a trigger for the maintainer to have a look at it and commit it to the code base. Or set it back to `Needs work` mentioning what is wrong with it and needs to be corrected.

Looks like the lack of response to #22 and #23 justifies this issue being `Needs work`

In addition the request from the maintainer was from before the posting of the patch. The waiting is on the patch to be confirmed working.

donapis’s picture

I've applied patch #11 and as @puch147 mentioned, can't place the block.

donapis’s picture

So, i manage to place the block. In src/Plugin/Block/VisitorsBlock.php
change use Drupal\Block\BlockBase; to use Drupal\Core\Block\BlockBase;

jurgenmo’s picture

Thank @donapis for your reply, I confirm that the module is working properly now!

hoporr’s picture

Patch #11 plus fix from #27 all work well.

hoporr’s picture

Status: Needs work » Reviewed & tested by the community

Seems like enough have tested this to move the status up. All we need now is a maintainer to make this an official release, if only an alpha or beta.

hoporr’s picture

One more mini-fix:
in src/Plugin/Block/VisitorsBlock.php
change the '!' to an '@' ( '!' is apparently not valid any longer in D8)

$this->items[] = t('Last Registered User: !last_user',
    array('!last_user' => drupal_render($username))
);

to

$this->items[] = t('Last Registered User: @last_user',
    array('@last_user' => drupal_render($username))
);
mmjvb’s picture

Status: Reviewed & tested by the community » Needs work
rafuel92’s picture

StatusFileSize
new56.11 KB

Hello guys, in this patch i've included also #27 and #31, now it should be ok.

rafuel92’s picture

Status: Needs work » Needs review
rafuel92’s picture

i hope we'll find a maintainer, i'm still available as maintainer of this project.

mmjvb’s picture

See https://www.drupal.org/node/251466 as this project appears to be abandoned.

@rafue92 You need to file a proper request to become co-maintainer.

rafuel92’s picture

Ok, i've just created the request here: https://www.drupal.org/project/visitors/issues/3037368

mmjvb’s picture

Status: Needs review » Needs work

Not convinced that the change from date to dateformatter is done as it should.
- Why would you inject something that is not used? Can only think of the argument of consistency, but consider that misplaced. Suggest removing when not used.
- When injecting you should use DateFormatterInterface, not the full path to DateFormatter instead.
- When injecting you should use $date_formatter instead of $date.

sah62’s picture

StatusFileSize
new3.25 KB

I've installed Visitors 8.x-2.1, and while there are no errors I'm also not seeing any visitor information. I'm not using the GeoIP or Browscap modules. When I load my /visitors page I see a "You do not have any administrative items" message as shown in the attached image file. I do see a summary in the visitor block.

I can see the configuration page at admin/config/system/visitors, but I don't see an entry for Visitors on admin/config/system. It would probably be a good idea to put a menu item there.

  • rafuel92 committed b5b43c2 on 8.x-2.x
    fixes jquery.jqplot graphs reports, fixes #2599042
    
rafuel92’s picture

Status: Needs work » Needs review

Hello @mmjvb and @sah62 i think everything it's fixed in the new release 8.x-2.2, can you check? thanks

sah62’s picture

It's better, now I see administrative items. When I try to save referer info I'm getting an error:

Error: Cannot use object of type Drupal\Core\Form\FormState as array in Drupal\visitors\Form\Referers->submitForm() (line 49 of /var/www/mysite/web/modules/contrib/visitors/src/Form/Referers.php)
#0 [internal function]: Drupal\visitors\Form\Referers->submitForm(Array, Object(Drupal\Core\Form\FormState))
#1 /var/www/mysite/web/core/lib/Drupal/Core/Form/FormSubmitter.php(111): call_user_func_array(Array, Array)
#2 /var/www/mysite/web/core/lib/Drupal/Core/Form/FormSubmitter.php(51): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState))
#3 /var/www/mysite/web/core/lib/Drupal/Core/Form/FormBuilder.php(590): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState))
#4 /var/www/mysite/web/core/lib/Drupal/Core/Form/FormBuilder.php(319): Drupal\Core\Form\FormBuilder->processForm('visitors_refere...', Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/mysite/web/core/lib/Drupal/Core/Form/FormBuilder.php(217): Drupal\Core\Form\FormBuilder->buildForm('visitors_refere...', Object(Drupal\Core\Form\FormState))
#6 /var/www/mysite/web/modules/contrib/visitors/src/Controller/Report/Referers.php(69): Drupal\Core\Form\FormBuilder->getForm('Drupal\\visitors...')
#7 [internal function]: Drupal\visitors\Controller\Report\Referers->display()
#8 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#9 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#10 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#11 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#12 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#13 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#14 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#15 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#16 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/mysite/web/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(165): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 /var/www/mysite/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#20 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#21 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#22 /var/www/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /var/www/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(693): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /var/www/mysite/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#25 {main}.

When I try to view user activity I get this error:

Error: Call to undefined function Drupal\visitors\Controller\Report\module_exists() in Drupal\visitors\Controller\Report\UserActivity->_getHeader() (line 108 of /var/www/mysite/web/modules/contrib/visitors/src/Controller/Report/UserActivity.php)
#0 /var/www/mysite/web/modules/contrib/visitors/src/Controller/Report/UserActivity.php(63): Drupal\visitors\Controller\Report\UserActivity->_getHeader()
#1 [internal function]: Drupal\visitors\Controller\Report\UserActivity->display()
#2 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#3 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#4 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#5 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#6 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#7 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#8 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#9 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#10 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#11 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#12 /var/www/mysite/web/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(165): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#13 /var/www/mysite/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#14 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#15 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#16 /var/www/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(693): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/mysite/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#19 {main}.

I haven't done exhaustive testing. This is what I've found so far.

sah62’s picture

I'm also seeing these errors in my watchdog log:

Error: Call to a member function getDefault() on null in Drupal\visitors\EventSubscriber\KernelTerminateSubscriber->_getTitle() (line 100 of /var/www/mysite/web/modules/contrib/visitors/src/EventSubscriber/KernelTerminateSubscriber.php)
#0 /var/www/mysite/web/modules/contrib/visitors/src/EventSubscriber/KernelTerminateSubscriber.php(55): Drupal\visitors\EventSubscriber\KernelTerminateSubscriber->_getTitle()
#1 [internal function]: Drupal\visitors\EventSubscriber\KernelTerminateSubscriber->onTerminate(Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#2 /var/www/mysite/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#3 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(88): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.terminat...', Object(Symfony\Component\HttpKernel\Event\PostResponseEvent))
#4 /var/www/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(32): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#5 /var/www/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(671): Stack\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#6 /var/www/mysite/web/index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#7 {main}.

rafuel92’s picture

Hello @sah62, this should be fixed in 8.x-2.3, can you check? thanks

sah62’s picture

I'm not seeing the errors I reported above. I'll let it run for a bit and report back in a day or so.

sah62’s picture

No more errors as far as I can tell. Thanks for the work!

rafuel92’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.