When I tried to install this module for drupal 8 it give me following error
:
RuntimeException: Failed to start the session because headers have already been sent by "/var/www/html/drupal/drupal8/modules/visitors/src/EventSubscriber/KernelTerminateSubscriber.php" at line 189. in Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage->start() (line 144 of /var/www/html/drupal/drupal8/vendor/symfony/http-foundation/Session/Storage/NativeSessionStorage.php).
If you try to uninstall this module, it produces an error like so:
Drupal\Core\Config\ImmutableConfigException: Can not delete immutable configuration visitors.config. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->delete() (line 56 of /var/www/html/drupal/drupal8/core/lib/Drupal/Core/Config/ImmutableConfig.php)
| Comment | File | Size | Author |
|---|---|---|---|
| #39 | visitors.png | 3.25 KB | sah62 |
| #33 | make_d8_release_of-2599042-33.patch | 56.11 KB | rafuel92 |
| #22 | Screenshot at feb 21 22-19-07.png | 282.24 KB | rafuel92 |
| #11 | make_d8_release_of-2599042-11.patch | 56.93 KB | rafuel92 |
| #8 | portingd8.3.x-2599042-8.patch | 49.15 KB | rafuel92 |
Comments
Comment #2
Pierre.Vriens commentedThe 8.x-2.0 release of this module, from 2014, was created way before I became the new maintainer of this module. This specific release, which also dates from before the official release of D8, has stopped working.
Until that is fixed, I've changed the release status from "Recommended" to "Other".
Anybody interested in speeding up things to get it to work: appropriate patches welcome!
Comment #3
Pierre.Vriens commentedComment #4
omlx commentedThis is what I modified to get the module uninstalled. in visitors.install file:
Comment #5
shreya shetty commentedi have provided the patch for the same
Comment #6
Pierre.Vriens commentedMerci (oeps: thank you!) @Shreya Shetty ! Would be nice if "somebody" would be able/willing to submit a similar patch for #2599042: Make D8 release of Visitors work again ... (which will probably take a few more lines of changes though ...).
Comment #7
a_anbarasan commentedunable to uninstall this module now,
eagerly waiting for this module ,bug fixed and supporting version D8..
Comment #8
rafuel92 commentedHello, first of all thanks for this module, i'm glad to inform you that i've performed an initial porting to Drupal 8.3.x, attached you can find a patch that makes this module work again, it generates statistical charts correctly now using jquery.jqplot library, i'm working also on visitors_geoip to provide geo stats and i'll release a separate patch in next days.
I suggest to create a new 8.x-3.0 dev version with this patch.
Comment #9
rafuel92 commentedHello, this is the release that fixes also visitors_geoip.module, now the module provides also stats about countries and cities.
Comment #10
rafuel92 commentedNew patch
Comment #11
rafuel92 commentedThat's the right patch with all the relevant changes, it includes :
visitors module and visitors_geoip module
Comment #12
leeksoup commentedDoes Visitors module still have a project maintainer?
If so, can that person check / add this patch of @rafuel92?
If not, is it possible @rafuel92 will want to be added as a maintainer?
Comment #13
rafuel92 commentedHello @leeksoup, become maintainer of the D8 version for me is not a problem, i have also additional improvements to release.
Comment #14
rafuel92 commentedAny good news? :)
Comment #15
rajeshreeputraAny Good news for Visitors Module????
Comment #16
rafuel92 commentedYes @Rajeshreeputra, i've developed a patch that makes the module work again.
The patch includes :
visitors module and visitors_geoip module, i'm waiting to become maintainer of the D8 Version or for the patch that i've produced to be committed.
Comment #17
websiteworkspace commentedWhat is the expected timeframe for a working D8 version of this module?
Comment #18
rafuel92 commentedHello the patch at #11 that i've provided makes this module work again.
Comment #19
websiteworkspace commentedWhat is the expected timeframe for committing the noted patch to a dev or stable release of this module?
At present there hasn't been a new release, dev or stable, of this module since 7 June 2014.
Comment #20
rafuel92 commentedI’ve posted the patch but actually i’m not the maintainer, so i can’t commit the patch on the repository because i don’t have the privileges.
Comment #21
dbjpanda commentedI am getting error after applying the patch #11.
Comment #22
rafuel92 commentedHello @dbjpanda, i suppose that you've already installed the visitors module and something went wrong during the installation phase.
You can try again on a fresh drupal 8 install (with a clean database) and enable the module, it will give the result available in the attached screenshot.
Comment #23
jurgenmo commentedI've applied patch #11, now I can get to the settings page (admin/config/system/visitors) and save the settings.
I see the block in the block lay-out list, but can't place the block. If i click on it notting happens.
Comment #24
cestmoi commented@Pierre.Vriens
@rafuel92 kindly submitted a patch months ago and yet no maintainer seems interested in saying a word about the fate of this port !
Comment #25
mmjvb commentedDon't know how this project uses the issue queue, but Status `Needs work` normally means it is not ready for committing to th code base. It means that something needs to be done first. After which it would go to `Needs review` and hopefully people try it out and confirm resolving the issue by setting to `RTBC`. That is a trigger for the maintainer to have a look at it and commit it to the code base. Or set it back to `Needs work` mentioning what is wrong with it and needs to be corrected.
Looks like the lack of response to #22 and #23 justifies this issue being `Needs work`
In addition the request from the maintainer was from before the posting of the patch. The waiting is on the patch to be confirmed working.
Comment #26
donapis commentedI've applied patch #11 and as @puch147 mentioned, can't place the block.
Comment #27
donapis commentedSo, i manage to place the block. In src/Plugin/Block/VisitorsBlock.php
change use Drupal\Block\BlockBase; to use Drupal\Core\Block\BlockBase;
Comment #28
jurgenmo commentedThank @donapis for your reply, I confirm that the module is working properly now!
Comment #29
hoporr commentedPatch #11 plus fix from #27 all work well.
Comment #30
hoporr commentedSeems like enough have tested this to move the status up. All we need now is a maintainer to make this an official release, if only an alpha or beta.
Comment #31
hoporr commentedOne more mini-fix:
in src/Plugin/Block/VisitorsBlock.php
change the '!' to an '@' ( '!' is apparently not valid any longer in D8)
to
Comment #32
mmjvb commentedComment #33
rafuel92 commentedHello guys, in this patch i've included also #27 and #31, now it should be ok.
Comment #34
rafuel92 commentedComment #35
rafuel92 commentedi hope we'll find a maintainer, i'm still available as maintainer of this project.
Comment #36
mmjvb commentedSee https://www.drupal.org/node/251466 as this project appears to be abandoned.
@rafue92 You need to file a proper request to become co-maintainer.
Comment #37
rafuel92 commentedOk, i've just created the request here: https://www.drupal.org/project/visitors/issues/3037368
Comment #38
mmjvb commentedNot convinced that the change from date to dateformatter is done as it should.
- Why would you inject something that is not used? Can only think of the argument of consistency, but consider that misplaced. Suggest removing when not used.
- When injecting you should use DateFormatterInterface, not the full path to DateFormatter instead.
- When injecting you should use $date_formatter instead of $date.
Comment #39
sah62 commentedI've installed Visitors 8.x-2.1, and while there are no errors I'm also not seeing any visitor information. I'm not using the GeoIP or Browscap modules. When I load my /visitors page I see a "You do not have any administrative items" message as shown in the attached image file. I do see a summary in the visitor block.
I can see the configuration page at admin/config/system/visitors, but I don't see an entry for Visitors on admin/config/system. It would probably be a good idea to put a menu item there.
Comment #41
rafuel92 commentedHello @mmjvb and @sah62 i think everything it's fixed in the new release 8.x-2.2, can you check? thanks
Comment #42
sah62 commentedIt's better, now I see administrative items. When I try to save referer info I'm getting an error:
When I try to view user activity I get this error:
I haven't done exhaustive testing. This is what I've found so far.
Comment #43
sah62 commentedI'm also seeing these errors in my watchdog log:
Comment #45
rafuel92 commentedHello @sah62, this should be fixed in 8.x-2.3, can you check? thanks
Comment #46
sah62 commentedI'm not seeing the errors I reported above. I'll let it run for a bit and report back in a day or so.
Comment #47
sah62 commentedNo more errors as far as I can tell. Thanks for the work!
Comment #48
rafuel92 commented