Closed (won't fix)
Project:
Juicebox HTML5 Responsive Image Galleries
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Nov 2014 at 22:42 UTC
Updated:
31 Jan 2015 at 20:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rjacobs commentedIt'll probably be best to do this in D8 first and then backport.
Comment #2
rjacobs commentedHere's a draft patch for the local testbots.
Comment #5
rjacobs commentedTest failures are from changes just committed in #2382533: Attach assets only via the asset library system, which adds a new issue that has to be delt with for this module.
Comment #6
rjacobs commentedHead changed, so here's an updated patch.
Comment #8
rjacobs commentedYeah, so reverse-engineering the way D8 core adds views-based tests turned out to be a bloody nightmare (we need a view to test a case where a gallery display is dependent on the cache). I think I finaaaaaalllly figure it out. Here's a new patch.
Comment #10
rjacobs commentedOk, committed. Now back to D7.
Comment #11
rjacobs commentedHere's a backport for D7.
Comment #13
rjacobs commentedHummm, let's try that again.
Comment #15
rjacobs commentedWell bloddy hell, I simply cannot replicate locally whatever error the testbots are spitting back. It's clearly related to the new test logic and not the changed code. I guess I'll have to figure out some creative way to debug this.
Comment #17
rjacobs commentedMight have been a stupid oversight regarding the fact that the testbots force non-clean URLs. Trying again...
Comment #18
rjacobs commentedAlright, so there are working versions of this available for both D7 and D8. However, the more I experiment with this cache logic the more I feel a bit uneasy about it. The concerns that come up include:
So I'm just a bit uneasy about things and will probably continue to look into some other ideas.
Comment #20
rjacobs commentedI'm going to go with a "sub-request" concept to solve this problem, as outline in #2401389: Consider alternate ways to store and generate gallery XML. It should be much cleaner to do it that way. As a result, this can be closed.