To reproduce install Drupal 7.33, add and enable the module.
Result: messages are not shown (see attached file).
I think it connected with last update in core theme.inc (http://cgit.drupalcode.org/drupal/commit/includes/theme.inc?h=7.x&id=444...)
Need more research.
Please fix!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mecmartini’s picture

Subscribe

mecmartini’s picture

I tried to make a patch, it seems to work for me.

I also fixed some drupal coding standard issues that I found.

Jonathan Young’s picture

Patch worked great for me, Thanks :-)

le72’s picture

mechmartini, can you confirm that issue fix is :

-	$message = drupal_get_messages($display['display'], FALSE);
+	$message = drupal_get_messages($display['display']);

and the rest of the patch is styling fix and theme function improvement?
Thanks for patch!

mecmartini’s picture

Hi @Ie72,

no there are many rows affected by the fix:

-    	'arguments' => array('display' => NULL),
+    	'variables' => array('messages_drupal' => array()),
-    	'arguments' => array('content' => NULL),
+    	'variables' => array('content' => NULL),
-	$message = drupal_get_messages($display['display'], FALSE);
+	$message = drupal_get_messages($display['display']);
-		$message = theme('better_messages_content', $display['display']);
+		$message = theme('better_messages_content', array('messages_drupal' => $message));
-	else { $output = theme('better_messages_content', $display['display']);}
+	else {
+  	$output = theme('better_messages_content', array('messages_drupal' => $message));
+  }
-function theme_better_messages_content($display = NULL) {
+function theme_better_messages_content($variables) {
-	foreach (drupal_get_messages($display) as $type => $messages) {
+	foreach ($messages_drupal as $type => $messages) {
gbirch’s picture

Priority: Major » Critical

Given that the module simply does not appear to work with Drupal 7.33 (i.e. actual messages are not displayed at all, and a blank message box is displayed) and has no workaround, this seems like a critical issue, rather than major, no?

brainHax’s picture

The patch worked but the theme of the box is not the same. The rounded corners are gone. Any CSS fixes for this ?

mecmartini’s picture

@brainHax my theme is still the same, with rounded corner. Maybe it's an issue with your theme, and in any case not related to this issue I guess.

satvision83’s picture

@mecmartini
Thank you for your patch. It's working great!

samerjh’s picture

Thanks for your patch @mecmartini , It's working.

bcobin’s picture

Thanks a ton for this - patch from #2 worked great - nice work!

gjones’s picture

Thank you mecmartini!

le72’s picture

Status: Needs review » Reviewed & tested by the community

  • le72 committed d96661c on 7.x-1.x authored by mecmartini
    Issue #2372515 by mecmartini, le72: Fix for new version of Drupal
    
le72’s picture

Status: Reviewed & tested by the community » Fixed

  • le72 committed d96661c on 8.x-1.x authored by mecmartini
    Issue #2372515 by mecmartini, le72: Fix for new version of Drupal
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.