Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To reproduce install Drupal 7.33, add and enable the module.
Result: messages are not shown (see attached file).
I think it connected with last update in core theme.inc (http://cgit.drupalcode.org/drupal/commit/includes/theme.inc?h=7.x&id=444...)
Need more research.
Please fix!
Comment | File | Size | Author |
---|---|---|---|
#2 | fix-messages-templates-variables-and-various-standard-coding-2372515-2.patch | 4.91 KB | mecmartini |
last_drupal_local_admin_modules.png | 26.02 KB | le72 |
Comments
Comment #1
mecmartini CreditAttribution: mecmartini commentedSubscribe
Comment #2
mecmartini CreditAttribution: mecmartini commentedI tried to make a patch, it seems to work for me.
I also fixed some drupal coding standard issues that I found.
Comment #3
Jonathan Young CreditAttribution: Jonathan Young commentedPatch worked great for me, Thanks :-)
Comment #4
le72mechmartini, can you confirm that issue fix is :
and the rest of the patch is styling fix and theme function improvement?
Thanks for patch!
Comment #5
mecmartini CreditAttribution: mecmartini commentedHi @Ie72,
no there are many rows affected by the fix:
Comment #6
gbirch CreditAttribution: gbirch commentedGiven that the module simply does not appear to work with Drupal 7.33 (i.e. actual messages are not displayed at all, and a blank message box is displayed) and has no workaround, this seems like a critical issue, rather than major, no?
Comment #7
brainHax CreditAttribution: brainHax commentedThe patch worked but the theme of the box is not the same. The rounded corners are gone. Any CSS fixes for this ?
Comment #8
mecmartini CreditAttribution: mecmartini commented@brainHax my theme is still the same, with rounded corner. Maybe it's an issue with your theme, and in any case not related to this issue I guess.
Comment #9
satvision83 CreditAttribution: satvision83 commented@mecmartini
Thank you for your patch. It's working great!
Comment #10
samerjh CreditAttribution: samerjh commentedThanks for your patch @mecmartini , It's working.
Comment #11
bcobin CreditAttribution: bcobin commentedThanks a ton for this - patch from #2 worked great - nice work!
Comment #12
gjones CreditAttribution: gjones commentedThank you mecmartini!
Comment #13
le72Comment #15
le72