Explain realm = 'all' [#210651]

Comment	File	Size	Author
#6	devel_node_access.explain_all.6.D5.patch	818 bytes	salvis

#4	devel_node_access.explain_all.4.D6.patch	829 bytes	salvis

	devel_node_access.explain_all.D6.patch	674 bytes	salvis

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 17 January 2008 at 04:23

Status:

Needs review

» Fixed

i modified the if clause and text a bit. commtted. thanks.

Log in or register to post comments

Comment #2

salvis

he/his

CreditAttribution: salvis commented 18 January 2008 at 00:47

With

   $row->nid == 0

you've tightened the if a bit too much. I get the nid(s) of the node(s) that are currently showing, not 0, and dna is even showing the node title(s).

Also wondering whether there might be other grants than 1/0/0, in which case the text would be wrong.

Log in or register to post comments

Comment #3

moshe weitzman CreditAttribution: moshe weitzman commented 18 January 2008 at 14:18

not sure i understand. but anyway, i added the check for nid == 0 so that i could use the text than mentions view specifically. no other module defined a record for nid == 0.

Log in or register to post comments

Comment #4

salvis

he/his

CreditAttribution: salvis commented 18 January 2008 at 22:33

File	Size
devel_node_access.explain_all.4.D6.patch	829 bytes

Sorry, this was too short.

The

0 / all / 0 / 1 / 0 / 0

record is only present if no node access module is installed. Installing one (e.g. ACL), even if it isn't active, causes Drupal to replace that one record with

NID / all / 0 / 1 / 0 / 0

records, one for each node.

So, I propose the attached change to HEAD.