The NavBar doesn't respect menu attributes such as target="_blank" (supplied by menu_attributes module).
Is this a possibility in a future release, or is it an issue with BootStrap?

Comments

pirog’s picture

please provide some more details here. Where are you trying to add in _blank?

Might also want to check out this.

pirog’s picture

Just following up here. Any additional details you can provide?

pirog’s picture

Status: Active » Postponed (maintainer needs more info)
pirog’s picture

Status: Postponed (maintainer needs more info) » Fixed
pirog’s picture

Issue summary: View changes

add relevant module details

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

shortspoken’s picture

Issue summary: View changes
Status: Closed (fixed) » Active

Hello,

I just came across this issue when I was trying to add a "title" attribute and additional "class" to the main menu. I was wondering, why the Menu Attributes module is taking no effect on the main menu in Kalatheme? In the menu block it does.

Its probably an issue how the menu gets called in the page.tpl?

Any is help is highly appreciated! Thanks for the great theme by the way!
Cheers, Moritz

Ps. Using Kalatheme 1.1

pirog’s picture

Thanks for the info here... definitely something we can check out and might already be resolved in the 3.x branch if you want to give that a try first.

My guess might be that we might be dropping some normal drupal convention in favor of a Bootstrap one and maybe that is something Menu Attributes needs to get started. Will look into it.

That said, and in the meantime you can actually directly add classes and titles to the main and secondary menus via page.tpl in Kalatheme.

shortspoken’s picture

Wow. Thank you for the quick reply!

As I started a huge project when Kalatheme 1.1 was released (with Bootstrap 2) I didnt want to upgrade to Bootstrap 3... But I will have a look at the code in 3.x

Cheers.

pirog’s picture

Makes sense and prudent decision.

Will check this issue out for you and get back.

pirog’s picture

Status: Active » Fixed

@shortspoken, i've pushed a fix for this to both the 1.x and 3.x dev versions however since you might not want to upgrade in your circumstance here is the code diff to get it to work:
http://drupalcode.org/project/kalatheme.git/blobdiff/57e5e3801c8c0b0446c...

shortspoken’s picture

Great success! Thank you very much! Works like a charme. :)

BarwonHack’s picture

The Dude abides :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit f440e15 on 7.x-3.x, layout_builder by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, fake-new-branch by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x, icons, kalatheme-dropdown-class by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    
  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x, icons, kalatheme-dropdown-class by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x, icons, kalatheme-dropdown-class, master by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    

  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x, kalatheme-dropdown-class, master, casperjs, views-plugin-simplification by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module
    
  • Commit f440e15 on 7.x-3.x, layout_builder, 7.x-4.x, kalatheme-dropdown-class, master, casperjs, views-plugin-simplification by pirog:
    Issue #2032003 by smilne23, shortspoken: Support menu attributes module