If no author, node_access_example_author grant allows all anonyomous traffic to edit/delete node [#2011058]

Comment	File	Size	Author
#8	2011058-examples-node_access_author_grant-9.patch	5.39 KB	vlad.n

#8	2011058-examples-node_access_author_grant-8.patch	3.79 KB	vlad.n

#5	2011058-examples-node_access_author_grant-4.patch	1.6 KB	hefox

#3	2011058-examples-node_access_author_grant-2.patch	1.53 KB	hefox

Comment #1

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 3 June 2013 at 19:26

Thanks.

Have a patch?

Log in or register to post comments

Comment #2

hefox CreditAttribution: hefox commented 3 June 2013 at 19:33

Not yet, corresponding core issue #2011066: example_author from hook_node_grants/hook_node_access_records grants all anon edit/delete to uid=0 nodes

Log in or register to post comments

File	Size
2011058-examples-node_access_author_grant-2.patch	1.53 KB

Comment #4

4 June 2013 at 01:10

Status:

Needs review

» Needs work

The last submitted patch, 2011058-examples-node_access_author_grant-2.patch, failed testing.

Log in or register to post comments

File	Size
2011058-examples-node_access_author_grant-4.patch	1.6 KB

Comment #6

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 6 June 2013 at 18:17

I'd wager that this lapse happened because there's no test of behavior for anonymous users.

Care to write one? :-)

Log in or register to post comments

Comment #7

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 11 June 2013 at 18:06

Status:	Needs review	» Needs work
Issue tags:		+Needs tests, +Novice

Just changing the status and tags.

And clarifying: The patch looks good, just needs a regression test. If anyone ever wanted to learn how to write a test, here's your chance. :-)

Log in or register to post comments

Comment #8

vlad.n CreditAttribution: vlad.n commented 8 March 2014 at 17:37

Issue summary:

View changes

File	Size
2011058-examples-node_access_author_grant-8.patch	3.79 KB

2011058-examples-node_access_author_grant-9.patch	5.39 KB

Added tests, verifying the access of an anonymous user to the private nodes with known or anonymous author. Testing the nodes that don't have an author was done using the nodes that were already made in the test and removing the author and moving back to the original auther after the test. I think that these test needs more refactoring.