Consolidate messages about unsaved changes [#1976032]

We currently have various ways in which we describe to the user to press the "Save" button. I have always found this messaging rather unfriendly, although the reminder has proven to be effective. Its often incredibly wordy, and gives the impression that it thinks I am stupid in the fact that it is saying to press the Save button.

Before

We could easily make this a lot shorter and more consistenct across core. I don't think we really need to hint at the actual submit button. All we have to remind people of, is the fact that they have unsaved changes. So I propose to change it to:

You have unsaved changes.

This would result in a relatively simple message:

After

Screen Shot 2013-04-21 at 9.21.37 PM.png

Comment	File	Size	Author
#7	unsaved.changes.nospecialcasingblocks.patch	3.14 KB	Bojhan
#7
#2	unsaved.changes.fixed_.test.patch	3.17 KB	Bojhan
#2
	unsaved.changes.patch	2.35 KB	Bojhan

	Screen Shot 2013-04-21 at 9.21.37 PM.png	116.01 KB	Bojhan
	saving-changes.png	57.31 KB	Bojhan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 April 2013 at 20:14

Status:

Needs review

» Needs work

The last submitted patch, unsaved.changes.patch, failed testing.

Comment #2

Bojhan CreditAttribution: Bojhan commented 21 April 2013 at 20:18

Status:

Needs work

» Needs review

File	Size
unsaved.changes.fixed_.test.patch	3.17 KB

Fixing tests.

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 22 April 2013 at 07:25

Status:

Needs review

» Needs work

The first two are in JS, the third is in PHP. And in fact the second piece of JS is an override for the first piece if JS, specifically to tailor the text to the use case :)

So:
- the second instance (in block.js) should completely be removed, it'll automatically use the text in the first (in tabledrag.js)
- we should consider having something like Drupal.showUnsavedChangesMessage()

I'll ping nod_.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 22 April 2013 at 07:42

Status:

Needs work

» Needs review

One reason why this message existed in the first place in views, was that the view was never actually saved initially. That's not longer true with just one submit button on the views wizard.

+1 for the simplication.

Comment #5

dawehner

German

CreditAttribution: dawehner commented 22 April 2013 at 07:43

Status:

Needs review

» Needs work

Comment #6

nod_

French

Lille

CreditAttribution: nod_ commented 23 April 2013 at 07:53

What Wim says. The Drupal.theme.tableDragChangedWarning should be removed from block.js entirely.

Better than Drupal.showUnsavedChangesMessage() might be a Drupal.showMessages() or something handling the whole message area (that Drupal.announce() could use maybe?). Good point, I feel it's outside the scope of this issue though.