On line 197:

/**
   * Overrides \Drupal\Core\Entity\Entity::getRevisionId().
   */

Yet the function is actually uri()

CommentFileSizeAuthor
#7 1967144-fix-docblock-updated-standards.patch1.44 KBtim-e
#1 1967144-fix-dockblock.patch648 bytestim-e
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim-e’s picture

tim-e CreditAttribution: tim-e commented
Assigned: Unassigned » tim-e
FileSize
1967144-fix-dockblock.patch648 bytes

Patch

tim-e’s picture

tim-e CreditAttribution: tim-e commented
Status: Active » Needs review
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

assuming bot agrees

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1967144-fix-dockblock.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review

#1: 1967144-fix-dockblock.patch queued for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Needs work

Hmm, there is a new standard for overrides/inherits

http://drupal.org/coding-standards/docs#inheritdoc

So all functions in this file need to have that format instead.

tim-e’s picture

tim-e CreditAttribution: tim-e commented
Status: Needs work » Needs review
FileSize
1967144-fix-docblock-updated-standards.patch1.44 KB

Patch for new doc standards

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

I think this warrants a fix now instead of in a bulk cleanup due to the current comment on the uri() function being incorrect.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: tim-e » jhodgdon

Thanks! I agree this warrants a fix now and I'll get it committed shortly.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks again -- committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.