Automated project review reported several errors that we should be able to fix without too much trouble, since it's mostly coding standards errors (spaces missing, wrong indent, missing empty lines, etc...).

Let's try to bring back module's code in compliance with coding standards and fix all validation errors.

There shouldn't be any change of code, other than the ones recommended by the coding standards PAReview.

Additionally, I assume these changes could also be back-ported on other branches: 6.x-1.x PAReview report, 5.x-1.x PAReview report

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on any aspects of this issue, I would be glad to provide more information or explain in more details.

Any questions, feedback, testing, changes, recommendations would be highly appreciated.
Thanks to all in advance.

Comments

DYdave’s picture

DYdave CreditAttribution: DYdave commented
Status: Active » Fixed

Quick follow-up on this issue:

PAReview is not prompting any errors anymore for all branches:

For all these versions, I didn't do any complicated changes, just fixed the errors as indicated by the reports: wrong spaces, break down too long inline comments, standardize Doc comments blocks, add full stops at end of lines of inline comments, etc....

I have tested a little bit and everything seem to work as expected, but I would greatly appreciate if you could let me know if anybody encounters any issue with the latest commits related with coding standards, I would surely try doing a quick fix as soon as possible.

Please let me know if you would have any questions, comments or issues regarding any of the commits or changes requested in this ticket, I would be glad to provide more information or explain in more details.
Thanks to all in advance for your feedback, testing and reviews.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

DYdave’s picture

DYdave CreditAttribution: DYdave commented
Issue summary: View changes

To prepare for new releases, quick checks of the coding standards on pareview.sh revealed the following minor errors:

For reroute_email-7.x-1.x


FILE: /var/www/drupal-7-pareview/pareview_temp/reroute_email.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
   5 | ERROR   | Doc comment short description must end with a full stop
  35 | WARNING | Format should be "* Implements hook_foo().", "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
     |         | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
 159 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/reroute_email.test
--------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------
  14 | ERROR | [ ] Doc comment short description must end with a full stop
  15 | ERROR | [ ] There must be exactly one blank line before the tags in a
     |       |     doc comment
  21 | ERROR | [ ] There must be exactly one blank line before the tags in a
     |       |     doc comment
  27 | ERROR | [ ] There must be exactly one blank line before the tags in a
     |       |     doc comment
  33 | ERROR | [ ] There must be exactly one blank line before the tags in a
     |       |     doc comment
 444 | ERROR | [x] Expected 1 space after comma in function call; 2 found
 464 | ERROR | [x] Expected 1 space after comma in function call; 2 found
 481 | ERROR | [x] Expected 1 space after comma in function call; 2 found
 492 | ERROR | [x] A cast statement must be followed by a single space
 502 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 271ms; Memory: 11Mb

 
For reroute_email-6.x-1.x


FILE: /var/www/drupal-7-pareview/pareview_temp/reroute_email.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 5 | ERROR | Doc comment short description must end with a full stop
--------------------------------------------------------------------------------

Time: 101ms; Memory: 5.75Mb

 
I went ahead, modified the code as suggested and committed the changes against reroute_email's 7.x-1.x branch at 19582f8 and 6.x-1.x branch at bab9042.
 
Feel free to let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on any of the latest code changes or this ticket in general, I would be glad to provide more information or explain in more details.
 
Thanks in advance to everyone for your testing, reviews, reporting and feedback.
Cheers!