It's fairly confusing that "Tip" plugins (TipPluginBase, TipPluginInterface...) are managed by TourManager rather than TipPluginManager...

FooBarPlugin <--> FooBarPluginManager, no ?

CommentFileSizeAuthor
#2 tour-tip_plugin_manager-1925576.patch4.46 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Title: "Tip" plugins managed by TourPluginManager ?? » "Tip" plugins managed by TourManager ??

Fixed actual class name.

Sure, TourManager is fun... - but quite misnamed :-)

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
tour-tip_plugin_manager-1925576.patch4.46 KB

Patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

RTBC, in case the bot comes back green.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Thanks guys, we missed this in the refactor, originally plugins wrapped the entities.

YesCT’s picture

YesCT CreditAttribution: YesCT commented

I added this issue to the summary of #1809352: Write tour.module and add it to core in the follow-up section.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Pity. :) That was funny.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

fixed actual class name