I've gone through the module code by hand and using coder.module and fixed some code style issues:
* Fixed issues reported by coder.module
* Fixed grammatical errors
* Removed commented-out code
* Fixed PHP errors
* Removed irrelevant comments
* Removed sponsorship texts
I know the last one may not be desirable for the module maintainer. I believe sponsorship information should go into a README.txt file and/or on the module page at Drupal.org, but not in the module itself. The same with the comments at the top of comment_notify.module with wishlists and whatnot. That's not where most people will look for that information.
There should be no functional changes from this patch other than a PHP error fix (see http://drupal.org/node/191313).
Comment | File | Size | Author |
---|---|---|---|
#5 | contrib-5.comment_notify.clean-up2.junyor.patch | 29.21 KB | Junyor |
contrib-5.comment_notify.clean-up.junyor.patch | 29.26 KB | Junyor | |
Comments
Comment #1
gregglesI agree with all of Junyor's fixes here. I'm testing them out and will report any oddities. So far, so good.
Comment #2
Junyor CreditAttribution: Junyor commentedAny updates on this, greggles?
Comment #3
gregglesThis works fine for me so far (I don't use it alot though, so it's hard to say) but I'd rather not commit a faulty fix for http://drupal.org/node/191313
Can you test out my proposed fix from that issue?
Comment #4
Junyor CreditAttribution: Junyor commented@greggles: Done. See my comment there.
Comment #5
Junyor CreditAttribution: Junyor commentedNew patch updated to HEAD with some additional clean-up.
Comment #6
gregglesGreat, thanks. I started to work on this today for 5 minutes so I'm glad you've re-rolled it.
Comment #7
gregglescommitted to the DRUPAL-5 branch. Thanks, Junyor!
Comment #8
Junyor CreditAttribution: Junyor commentedSweet!
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.