I've gone through the module code by hand and using coder.module and fixed some code style issues:

* Fixed issues reported by coder.module
* Fixed grammatical errors
* Removed commented-out code
* Fixed PHP errors
* Removed irrelevant comments
* Removed sponsorship texts

I know the last one may not be desirable for the module maintainer. I believe sponsorship information should go into a README.txt file and/or on the module page at Drupal.org, but not in the module itself. The same with the comments at the top of comment_notify.module with wishlists and whatnot. That's not where most people will look for that information.

There should be no functional changes from this patch other than a PHP error fix (see http://drupal.org/node/191313).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

I agree with all of Junyor's fixes here. I'm testing them out and will report any oddities. So far, so good.

Junyor’s picture

Any updates on this, greggles?

greggles’s picture

This works fine for me so far (I don't use it alot though, so it's hard to say) but I'd rather not commit a faulty fix for http://drupal.org/node/191313

Can you test out my proposed fix from that issue?

Junyor’s picture

@greggles: Done. See my comment there.

Junyor’s picture

New patch updated to HEAD with some additional clean-up.

greggles’s picture

Great, thanks. I started to work on this today for 5 minutes so I'm glad you've re-rolled it.

greggles’s picture

Status: Needs review » Fixed

committed to the DRUPAL-5 branch. Thanks, Junyor!

Junyor’s picture

Sweet!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.