In the patch attached, I have collected all the small changes that I needed to apply to be able to implement the layout for my current project. The changes included are

  • pass the panel name to theme functions via panels_render_panel
  • add custom CSS class and ID to all content types
  • don't flatten block content by calling theme('panels_custom_content') on it
  • some more checks for node id being numeric
  • do not unset the node title. My project's layout requires that the title be placed within the custom CSS attributes. I couldn't use the standard block title because this one is placed outside the DIV with the custom CSS class given in the panel.
  • show view offsets > 0 in panel title

. I have marked this as a feature request because certainly these changes are not necessary in every project. In my case, however, I wouldn't have known how to live without them.

--
Olav

CommentFileSizeAuthor
panels_4.patch8.24 KBolav
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Active » Fixed

I have accepted pretty much all of these, though in many of them the form has changed significantly.

The custom CSS ID/class stuff is now handled on an internal form so blocks don't have to specify it themselves.

The bit about not unsetting $node->title is optional -- basic themes will display the node title twice if we don't do this. I really don't like this but there's not a lot I can do about it, making it an option seemed like the easiest way to deal with it.

Some of these fixes I had already made, too.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.