Blocks should render the appropriate classes for zurb to work

Problem/Motivation

Blocks should use the approrpriate scaffolding classes provided in zurb

Proposed resolution

todo...

Comments

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
Assigned: Unassigned » chrisjlee
ishmael-sanchez’s picture

ishmael-sanchez CreditAttribution: ishmael-sanchez commented

Hi Chris,

My thinking on this is column widths defined in the page template would confine the blocks and if particular block/s need more classes that could be done using preprocessing or a template file. Let me know your thoughts on scaffolding classes.

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented

@ishmael-sanchez can you expand on this? Sorry, I'm not totally getting what you're trying to describe.

ishmael-sanchez’s picture

ishmael-sanchez CreditAttribution: ishmael-sanchez commented

Hi Chris,

Thanks for your note. Can you tell me what you are envisioning? You said

Blocks should use the approrpriate scaffolding classes provided in zurb

for your motivation, so I'm just trying to address issues in the queue. Let me know what you think.

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented

@ishmael-sanchez Oh i see. Well, I'm just trying to go off of your particular task ( #1779074: Clean up markup in some default Drupal templates and functions ) so that we can all move toward a stable release.

What i was interpreting from your task was that you download the drupal zurb theme each block should demonstrate block class usage in action. There should be some example blocks that come with this theme that you can enable and disable by renaming the file name, etc.

So for every block they should have a column class and the how many grid widths it should take: 

<div class="block block-{delta} column">
  <div class="block-title"></div>
  <div class="content">...</div>
</div>

Possibly even an example page that mimics the foundation docs:
http://foundation.zurb.com/docs/grid.php

What were you envisioning?

ishmael-sanchez’s picture

ishmael-sanchez CreditAttribution: ishmael-sanchez commented
Assigned: chrisjlee » ishmael-sanchez
Status: Active » Fixed

Here is what was done and committed:

In the core theme

  • Removed ID's from block.tpl.php and added unique class instead
  • Added default block title class
  • Added some sane region based classes

In starter

  • Example of adding Foundation grid/mobile classes
  • Example of template suggestions based on module
  • Added an example of adding a div with a generic class
  • Examples of block specific styling

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.