about

commerce europabank is a payment provider for Drupal Commerce.
It integrates drupal commerce with the Belgian europabank payment service who gives access to visa, mastercard and maestro payments.
The module currently runs on 2 live websites without problems.

How to test

You can test this module by creating a test account at https://www.ebonline.be/test/home.jsp?link=register&lang=nl
After you have registered for a test account europabank wil mail you some test cards and login information.

After enabeling the module you can enable the payment method at www.example.com/admin/commerce/config/payment-methods

The only thing left to do is edit the rules action and submit your test account data.

When everything is configured, just buy something at your store and choose online payment :)

extra information

drupal version: 7
project page: http://drupal.org/sandbox/wouters_frederik/1665578
git: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/wouters_frederik/1665578.git commerce_europabank

reviews

http://drupal.org/node/1856652#comment-6824090
http://drupal.org/node/1858712#comment-6830940
http://drupal.org/node/1864906#comment-6838238

CommentFileSizeAuthor
#5 coder-results.txt560 bytesklausi

Comments

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work

Hi,

there is a little bit work required. Please fix errors and warnings listed here: http://ventral.org/pareview/httpgitdrupalorgsandboxwoutersfrederik166557...

(please check the Drupal coding standards)

stijn.blomme’s picture

stijn.blomme commented

hi monymirza,

thank you for taking the time to test this module.
All the issues thrown by the automated review module have been fixed.

stijn.blomme’s picture

stijn.blomme commented
Status: Needs work » Needs review

set status back to needs review

stijn.blomme’s picture

stijn.blomme commented
Issue summary: View changes

fixed broken http://drupal.org/sandbox/wouters_frederik/1665578 link

stijn.blomme’s picture

stijn.blomme commented
Issue summary: View changes

added first review link

stijn.blomme’s picture

stijn.blomme commented
Issue summary: View changes

added second review link

stijn.blomme’s picture

stijn.blomme commented
Issue tags: +Commerce, +PAreview: review bonus

added issue tags for review and drupal commerce

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Commerce, -PAreview: review bonus +PAReview: Commerce
StatusFileSize
new coder-results.txt560 bytes

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

  1. "t(variable_get('europabank_payment_title', 'Online Payment (Visa, Mastercard, Maestro)')),": t() should always be used on literal strings where possible, i.e. on the default value and not around variable_get().
  2. "$form['#submit'][] = 'commerce_europabank_settings_form_submit';": that callback does not exist?
  3. commerce_europabank_get_feedback(): why do you map check_plain() here to the submitted values? You are not printing anything to the user in this function? Please read http://drupal.org/node/28984 again.
  4. "module_load_include('inc', 'commerce_europabank', 'commerce_europabank.sha1');": no need to use module_load_include as you are including files from your own module which you already know where they are. Use something like require_once 'mymodule.inc';

But that are not blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, stijn.blomme!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

added 3rd review