In #1771944: Replace exported views in tests with config files, views_test.module is renamed to views_test_data.module, but for sanity-preserving-purposes, the schema name and variable names are untouched.

CommentFileSizeAuthor
#19 1774278-updateviewstest-views-19.patch81.08 KBACF
#17 1774278-updateviewstest-views-17.patch80.96 KBACF
#15 1774278-updateviewstest-views-15.patch81.01 KBACF
#14 1774278-updateviewstest-views-13.patch73.47 KBACF
#12 1774278-updateviewstest-views-11.patch73.47 KBACF
#9 1774278-updateviewstest-views-9.patch73.46 KBACF
#7 1774278-updateviewstest-views-7.patch4.8 KBACF
#3 1774278-updateviewstest-views-3.patch4.82 KBACF
#1 1774278-updateviewstest-views-1.patch4 KBACF
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Active » Needs review
FileSize
1774278-updateviewstest-views-1.patch4 KB

Got a fix for this hopefully.

Status: Needs review » Needs work

The last submitted patch, 1774278-updateviewstest-views-1.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1774278-updateviewstest-views-3.patch4.82 KB

Missed a change.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Issue tags: -Novice, -VDC

#3: 1774278-updateviewstest-views-3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 1774278-updateviewstest-views-3.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-7.patch4.8 KB

rerolled

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work

This is missing the actual change to the schema, like
http://drupalcode.org/project/views.git/blob/refs/heads/8.x-3.x:/lib/Dru...

And then all of the base_table values in http://drupalcode.org/project/views.git/blob/refs/heads/8.x-3.x:/tests/v... etc

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-9.patch73.46 KB

Apologies missed the point. Hopefully this is better.

Status: Needs review » Needs work

The last submitted patch, 1774278-updateviewstest-views-9.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented 
+++ b/tests/views_test_data/config/views.view.test_click_sort.ymlundefined
@@ -1,5 +1,5 @@
-base_table: views_test
+base_table: views_test_base

These should be views_test_data, not views_test_base

And the failures indicate there are some that still weren't converted

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-11.patch73.47 KB

Status: Needs review » Needs work

The last submitted patch, 1774278-updateviewstest-views-11.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-13.patch73.47 KB
ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1774278-updateviewstest-views-15.patch81.01 KB

Missed one again :-(

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work

Now there are a few views_test_data_base, should just be views_test_data

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-17.patch80.96 KB

Removed the views_test_data_base

Status: Needs review » Needs work

The last submitted patch, 1774278-updateviewstest-views-17.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1774278-updateviewstest-views-19.patch81.08 KB

change the last views_test_name to views_test_data_name

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

Committed! Awesome.
http://drupalcode.org/project/views.git/commit/60da39f

Automatically closed -- issue fixed for 2 weeks with no activity.