use clean urls in gallery_menu [#176859]

Hi,
Gallery Menu Module URL's look like:

although I activated url rewriting/clean url and I can reach to my albums like:

http://example.com/v/izmir_ephesus_efes/

Is there any way to make menu urls like clean urls above.

Thanks

Comment	File	Size	Author
#6	gallery_menu_paths2.patch	3.93 KB	profix898
#4	gallery_menu_paths.patch	2.38 KB	profix898

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

profix898 CreditAttribution: profix898 commented 19 September 2007 at 14:22

Component:	Miscellaneous	» gallery_menu.module
Category:	support	» feature

In principle that should be possible, but its not yet supported. Marking this a feature request for gallery_menu.module. I'm currently busy with porting modules (including gallery*.module) to Drupal 6. But I will revisit this idea once the basic D6 port stands.

Comment #2

profix898 CreditAttribution: profix898 commented 2 October 2007 at 13:29

Priority:

Normal

» Critical

Raising priority. I'll try to improve url rewrite handling in general (see http://drupal.org/node/179803) and the gallery_menu paths in particular before the next beta (or RC) of the new module will be available. Here is a short todo list:

check for 'gallery/' being part of rewrite rules (and display warning if not on the install tab)
use G2 url rewrite schema/rules to generate paths in gallery_menu.module

Comment #3

profix898 CreditAttribution: profix898 commented 2 October 2007 at 16:02

A problem for #2 is that D5 menu does not support plus signs in paths. It automatically transforms e.g. 'Album+A' into 'Album%2BA', which is not recognized by G2 as a valid path. Is '+' a valid character in urls? Either Drupal or G2 seems to behave incorrectly here. G2 uses '+' to replace spaces in paths, i.e. for an album named 'Album A' G2 generates the url as 'gallery/v/Album+A/'.

Comment #4

profix898 CreditAttribution: profix898 commented 4 October 2007 at 16:47

Status:

Active

» Needs work

File	Size
gallery_menu_paths.patch	2.38 KB

Attached is a patch which makes the Drupal menu paths identical to the G2 album paths. However I cant get this to work correctly. Now that the Drupal paths look as expected the rewrite rules of G2 are interfering with the Drupal rules. I will need to investigate why and how we can prevent that. Also the Drupal menu system doesnt created nested menu items as one would expect for the paths.

Comment #5

profix898 CreditAttribution: profix898 commented 4 October 2007 at 18:10

One of the URL Rewrite rules for G2 look like ...

RewriteCond %{THE_REQUEST} /gallery/([^?]+)(\?.|\ .)
RewriteCond %{REQUEST_URI} !/index\.php$
RewriteRule .   /index.php?q=gallery&g2_path=%1   [QSA,L]

As this is at the beginning of the Drupal .htaccess file, every paths with 'gallery/*' is rewritten to '/index.php?q=gallery&g2_path='. Thats good for G2, but Drupal never receives the full path and therefore menu system doesnt work correctly (e.g. it doesnt recognize the path to highlight the active menu item). I'm inclined to say won't fix unless anyone has a good idea here :(

Comment #6

profix898 CreditAttribution: profix898 commented 5 October 2007 at 22:57

Status:

Needs work

» Needs review

File	Size
gallery_menu_paths2.patch	3.93 KB

Here is a patch which solves the problems mentioned above. This one is ready for testing. Anyone?

Comment #7

profix898 CreditAttribution: profix898 commented 10 October 2007 at 07:39

Title:	Gallery Menu Module URL	» use clean urls in gallery_menu
Status:	Needs review	» Fixed

I've just committed the patch to cvs. Please try and report any issues. I'm not convinced this is the best solution, but there is no clean way to do this (at least none I can think of).