Uppercase captcha and Captcha to CAPTCHA [#171183]

Comment	File	Size	Author
#21	captcha2CAPTCHA_10_smalladditionalstuff.patch	4.74 KB	soxofaan

#17	captcha2CAPTCHA_11.patch	54.37 KB	RobLoach

#16	captcha2CAPTCHA_10.patch	55.61 KB	soxofaan

#14	captcha2CAPTCHA_9_image_captcha_module.patch	6.79 KB	soxofaan

#13	captcha2CAPTCHA_9_captcha_module.patch	34.08 KB	soxofaan

#12	captcha.module.rej__0.txt	8.44 KB	RobLoach
#11	captcha2CAPTCHA_8_captcha_module.patch	31.66 KB	soxofaan

#10	captcha2CAPTCHA_8_apitxt.patch	5.94 KB	soxofaan

#9	captcha2CAPTCHA_8_infoinstall.patch	2.85 KB	soxofaan

#8	captcha2CAPTCHA_7.patch	52.6 KB	soxofaan

#7	captcha2CAPTCHA_6.patch	0 bytes	soxofaan

#6	captcha.module.rej_.txt	11.25 KB	RobLoach
#5	captcha2CAPTCHA_5.patch	52.39 KB	soxofaan

#1	captcha2CAPTCHA_4.patch	51.97 KB	soxofaan

Comment #1

soxofaan CreditAttribution: soxofaan commented 5 September 2007 at 08:48

File	Size
captcha2CAPTCHA_4.patch	51.97 KB

in this patch:

all occurrences of "captcha" in UI strings changed to "CAPTCHA" (I hope I catched them all)
added "CAPTCHA is a trademark of Carnegie Mellon University." to help string at admin/help/captcha
cleaned pleonasms like "CAPTCHA challenge"
worked a bit on the help strings

Log in or register to post comments

Comment #2

RobLoach

he/him

CreditAttribution: RobLoach commented 5 September 2007 at 08:55

Priority:	Normal	» Critical
Status:	Active	» Needs review

Whoa, big patch. I'll take a look over the next few days.

Log in or register to post comments

Comment #3

soxofaan CreditAttribution: soxofaan commented 5 September 2007 at 08:58

Whoa, big patch. I'll take a look over the next few days.

Would it be better/easier if I split it out per file?

Log in or register to post comments

Comment #4

RobLoach

he/him

CreditAttribution: RobLoach commented 5 September 2007 at 09:04

Nope! This is good :-) .

Log in or register to post comments

Comment #5

soxofaan CreditAttribution: soxofaan commented 8 September 2007 at 12:07

File	Size
captcha2CAPTCHA_5.patch	52.39 KB

update of patch (a.o. against captcha.module 1.42.2.28)
just cvs update conflict solving, nothing was added/changed

Log in or register to post comments

Comment #6

RobLoach

he/him

CreditAttribution: RobLoach commented 18 September 2007 at 15:13

Status:

Needs review

» Needs work

File	Size
captcha.module.rej_.txt	11.25 KB

Some hunks failed with this patch. It might need a re-issue..... The attached file is what was outputed.

Log in or register to post comments

Comment #7

soxofaan CreditAttribution: soxofaan commented 18 September 2007 at 15:59

File	Size
captcha2CAPTCHA_6.patch	0 bytes

updated patch (against latest version at the time of this writing)

Log in or register to post comments

Comment #8

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 08:28

File	Size
captcha2CAPTCHA_7.patch	52.6 KB

previous post had some problem apparently.
this one should do it

Log in or register to post comments

Comment #9

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 09:22

Status:

Needs work

» Needs review

File	Size
captcha2CAPTCHA_8_infoinstall.patch	2.85 KB

Because this issue changes almost every file of the module, the patches in this thread are big.
To make the reviewing/commiting easier and less risky, I decided to split the patches in smaller pieces.

I'll start with the simple ones: the info and install files (see attachment)

Log in or register to post comments

Comment #10

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 09:26

File	Size
captcha2CAPTCHA_8_apitxt.patch	5.94 KB

follow up on #9:
patch for captcha_api.txt

Log in or register to post comments

Comment #11

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 09:29

File	Size
captcha2CAPTCHA_8_captcha_module.patch	31.66 KB

follow up on #9:
patch for captcha.module

Log in or register to post comments

Comment #12

RobLoach

he/him

CreditAttribution: RobLoach commented 19 September 2007 at 15:25

Status:

Needs review

» Needs work

File	Size
captcha.module.rej__0.txt	8.44 KB

Yet another overlapped patch ;-) .

Log in or register to post comments

Comment #13

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 17:14

File	Size
captcha2CAPTCHA_9_captcha_module.patch	34.08 KB

new version of the patch from #11 (captcha.module)

Log in or register to post comments

Comment #14

soxofaan CreditAttribution: soxofaan commented 19 September 2007 at 17:17

File	Size
captcha2CAPTCHA_9_image_captcha_module.patch	6.79 KB

follow up on #9: patch for image_captcha.module

Log in or register to post comments

Comment #15

wundo CreditAttribution: wundo commented 20 September 2007 at 20:36

Priority:	Critical	» Minor
Status:	Needs work	» Closed (works as designed)

Sorry, but in my opnion it`s not really an issue.
Setting it as by design.

And I'm sure, this is not a critical task.

Please read my comments in Captcha`s group discution about this topic.

Log in or register to post comments

Comment #16

soxofaan CreditAttribution: soxofaan commented 25 September 2007 at 23:20

Priority:	Minor	» Critical
Status:	Closed (works as designed)	» Needs review

File	Size
captcha2CAPTCHA_10.patch	55.61 KB

I'm reviving this thread based on this suggestion I made in the CAPTCHA group discussion about the renaming issue. I also set it to critical because it has to be resolved before 3.0 final as Rob stated.

This patch not only changes "captcha" to "CAPTCHA", but also replaces it with just "challenge" as much as possible to minimize the typographic noise caused by the uppercase abbreviation "CAPTCHA".

In attachment the big patch (changes in 8 files).
I also made patches per file, but because this bug tracker does not accept zip/tar archives you can download a zip here (temporarily):
http://telin.ugent.be/~slippens/tmp/captcha2CAPTCHA_10_per_file.zip

Log in or register to post comments

Comment #17

RobLoach

he/him

CreditAttribution: RobLoach commented 26 September 2007 at 09:54

File	Size
captcha2CAPTCHA_11.patch	54.37 KB

I've reviewed captcha2CAPTCHA_10, and if we're going to be going with this new casing, this patch seems ready. All we need is wundo's thumbs up.

My thoughts:

Looks ugly and doesn't seem to fit in the administration page because everything else seems to go with PascalCasing or Title Casing
CAPTCHA is the "right" way to refer to the challenges (Wikipedia does it)
The way the .NET Framework cases acronyms is that it uses Camel Case, if the acronym is longer than four letters. So we'd have SMS Framework, LDAP, but for CAPTCHA, we'd end up with "Captcha".
When you do a Google search for captcha, the majority of results use "CAPTCHA"

.... I think that in the end, we're going to be making the move and we're going to have to do it before 3.0 is released. Even if we don't like its cosmetics (well, I don't), making this change is the "right" thing to do.

One thing I don't like with this patch is the change to "CAPTCHA" in the permissions (admin/user/access), because it changes the API. The attached patch is the same as 10, except without the permissions change.

Log in or register to post comments

Comment #18

soxofaan CreditAttribution: soxofaan commented 26 September 2007 at 11:53

One thing I don't like with this patch is the change to "CAPTCHA" in the permissions (admin/user/access), because it changes the API.

I don't consider changing the permission strings as "breaking the CAPTCHA API". I think, in principle, other challenge modules should not use these permissions since the base CAPTCHA module should do all the heavy lifting (sessions, permissions, validation, etc), while challenge modules should just provide a challenge. Are there modules that use these permissions?
Anyway, I just prefer the strings "administer CAPTCHA settings" and "skip CAPTCHA" above the current strings "administer captcha" and "skip captcha challenges", especially since "captcha challenge" is a pleonasm.