The theme_filter_tips() function has a $long attribute, which might have been inserted between the two attributes around it, since some of the function calls are not ready for passing that attribute. Therefor sometimes $long gets the $extra parameter value, and sometimes $long is missing (especially when long filter tips are displayed). Calling with the proper parameters fixes this issue.

Also the $tip['id'] is directly used as a HTML id. But $tip['id'] contains things like 'bbcode/0' and 'glossary/0' and therefore is not capable to being used as a HTML id. I prefixed the HTML id with 'filter-', as it used to be and converted the / to -, so the ids become 'filter-bbcode-0' and 'filter-glossary-0' respectively.

Patch attached. Might also be relevant for 4.5.x.

CommentFileSizeAuthor
#4 filter_16016.patch1.3 KBwulff
Drupal-various-bug-in-filter-tips.patch1.79 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

By the way, the long filter tips page also lacks a breadcrumb. All other pages have at least the 'Home' item in their breadcrumb, except the homepage of course. I don't know where to solve this. Call drupal_set_breadcrumb() or depend on the menu system? How?

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to HEAD.

Dries’s picture

Dries CreditAttribution: Dries commented

The breadcrumb is derived from the path registered to the menu system, however, it can be overwritten by drupal_set_breadcrumb().

wulff’s picture

wulff CreditAttribution: wulff commented
Version: » x.y.z
Status: Active » Needs review
FileSize
filter_16016.patch1.3 KB

The generated ID's are currently of the form 'filter-filter-n' (i.e. filter-filter-0, filter-filter-1, etc.)

The attached patch is a simple attempt at added breadcrumbs to the long filter tips page.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

Not exactly elegant. There must be a better way to do this, probably using the menu system.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Needs work » Fixed

I am setting this to "fixed" as the orginal issue was indeed fixed and the subsequent patch was deferred and not follow up happened.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)