Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Status: Active » Needs review
FileSize
185.37 KB
aspilicious’s picture

FileSize
185.36 KB

Previous one should fail...

Gábor Hojtsy’s picture

Issue tags: +sprint, +language-base

Adding sprint tag for D8MI. Thanks for working on this.

Status: Needs review » Needs work
Issue tags: -D8MI, -sprint, -PSR-0, -language-base

The last submitted patch, 1591950-locale-tests-2.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review

#2: 1591950-locale-tests-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D8MI, +sprint, +PSR-0, +language-base

The last submitted patch, 1591950-locale-tests-2.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
185.38 KB

Green please!

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

I did not review the tests line by line, trust @aspilicious that only the required changes were done. Since we are doing other test cleanup too (eg. #1561004: Many tests still reference locale although they only need language module) and this is a pain to reroll, let's get this in sooner than later.

catch’s picture

Committed/pushed to 8.x, thanks!

catch’s picture

Status: Reviewed & tested by the community » Fixed
Gábor Hojtsy’s picture

Issue tags: -sprint

Superb, thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.