@bdragon

Checking my firebug output this call seems to be a major performance bottleneck, maybe you can help me here.

1.) on every call to map/query/markers we have a call gmap_get_icondata(TRUE), which resets the cache - I think we should have such a call only somewhere in the admin-interface and use the cached result when possible from gmap_json_query()

2.) to make things even worse, when I have 3 maps on a page, there are 3 ajax requests to map/query/markers - and all seem to return the same result. I'm wondering if this should be an ajax call at all. Seems like a good candidate to write out with a in-document javascript section onto a global js-variable ...

What do you think?

Comments

bdragon’s picture

bdragon CreditAttribution: bdragon commented

1) I agree. I had the TRUE in there for debugging when I originally wrote that part, and I guess I forgot to remove it.
2) Oh, that would be a bug in js/icon.js then on line 181, apparently. I do a check to make sure I haven't already started loading the icons, but the check is per map instead of global...

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Assigned: Unassigned » bdragon

I'm working on this one today.

bdragon’s picture

bdragon CreditAttribution: bdragon commented
Status: Active » Fixed

Should be fixed. I figure we might as well skip using ajax in the first place. Also, I enabled the caching and added code to reset it when visiting the settings page.
http://drupal.org/cvs?commit=125847
http://drupal.org/cvs?commit=125848
http://drupal.org/cvs?commit=125850

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.