This is just a quick cleanup of based on Coder's review. Simple things. Got to it only because of a bug in Coder.

CommentFileSizeAuthor
#3 sharethis-code_clean-1498768-3.patch61.66 KBhswong3i
sharethis-coder-1.patch2.33 KBmgifford

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Fixed

Thanks! http://drupalcode.org/project/sharethis.git/commit/57119f9

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hswong3i’s picture

hswong3i commented
Status: Closed (fixed) » Needs review
StatusFileSize
new sharethis-code_clean-1498768-3.patch61.66 KB

More cleanup with:

P.S. For verify changes beside white space and indentation, please apply patch and run "git -w -b HEAD" ;-)

hswong3i’s picture

hswong3i commented

Anyone can give a hand for the review? Since I would like to start contribute for #1812382: Add bar style as display options? after code cleanup ;-)

robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

Some of those files are external files from ShareThis, so I left those changes out. Otherwise, looks good! Thanks a lot. http://drupalcode.org/project/sharethis.git/commit/a28f68a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.