In nodequeue_edit_queue_form() the page title will be set using drupal_set_title(). It is setting $info[$queue]['title'] to lower case before. I guess this is just a paste/copy typo.

CommentFileSizeAuthor
#1 nodequeue-1274026-1.patch546 bytesfuerst
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Active » Needs review
FileSize
nodequeue-1274026-1.patch546 bytes

Attached patch fixes this.

Status: Needs review » Needs work

The last submitted patch, nodequeue-1274026-1.patch, failed testing.

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Needs work » Needs review

Test failing unrelated to the patch in #1

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Closed (won't fix)

I tracked that strtolower() all the way back to http://drupalcode.org/project/nodequeue.git/commit/7ba394dc, and I don't see any reason to undo it.

fuerst’s picture

fuerst CreditAttribution: fuerst commented
Status: Closed (won't fix) » Needs review

One reason: If you support non-english languages where a word in the middle of a sentence can be capitalized this strtolower() just removes your capitals. Also this strtolower() seems to be there without any necessity so I hope it can be removed without hurting anything else.

Would appreciate it if you reconsider #4!

feuillet’s picture

feuillet CreditAttribution: feuillet commented

I'd recommend using text-transform in CSS Instead of strtolower() PHP. That way, anyone can overwrite it in his own template code instead of patching the module. Don't see a need to do that in PHP Code here. Had to patch the module too to accomplish customers requirements.

feuillet’s picture

feuillet CreditAttribution: feuillet commented
Status: Needs review » Reviewed & tested by the community
amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Reviewed & tested by the community » Fixed

Allright, talked about this with @ezra-g on IRC and he's ok with it.

Commited to 6.x-2.x and 7.x-2.x. Thanks :)

http://drupalcode.org/project/nodequeue.git/commit/00198a3
http://drupalcode.org/project/nodequeue.git/commit/37c79ea

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

corrected typo in the sentenze about the typo