Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.In nodequeue_edit_queue_form() the page title will be set using drupal_set_title(). It is setting $info[$queue]['title'] to lower case before. I guess this is just a paste/copy typo.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | nodequeue-1274026-1.patch | 546 bytes | fuerst |
Comments
Comment #1
fuerst commentedAttached patch fixes this.
Comment #3
fuerst commentedTest failing unrelated to the patch in #1
Comment #4
amateescu commentedI tracked that
strtolower()all the way back to http://drupalcode.org/project/nodequeue.git/commit/7ba394dc, and I don't see any reason to undo it.Comment #5
fuerst commentedOne reason: If you support non-english languages where a word in the middle of a sentence can be capitalized this
strtolower()just removes your capitals. Also thisstrtolower()seems to be there without any necessity so I hope it can be removed without hurting anything else.Would appreciate it if you reconsider #4!
Comment #6
feuillet commentedI'd recommend using text-transform in CSS Instead of strtolower() PHP. That way, anyone can overwrite it in his own template code instead of patching the module. Don't see a need to do that in PHP Code here. Had to patch the module too to accomplish customers requirements.
Comment #7
feuillet commentedComment #8
amateescu commentedAllright, talked about this with @ezra-g on IRC and he's ok with it.
Commited to 6.x-2.x and 7.x-2.x. Thanks :)
http://drupalcode.org/project/nodequeue.git/commit/00198a3
http://drupalcode.org/project/nodequeue.git/commit/37c79ea
Comment #9.0
(not verified) commentedcorrected typo in the sentenze about the typo