Revamp of i18n_taxonomy_term_get_translations()

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -722,33 +722,31 @@ function i18n_taxonomy_form_all_localize(&$item) {
+  if (is_numeric($i18n_tsid) && $i18n_tsid) {

That check is IMHO unecessary. It's a required argument and you pass in an invalid argument, bad things will happen. That's true for most drupal API functions. Also, is_numeric() actually allows things like "-123e12" so you can still pass in invalid stuff if you really want to.

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -722,33 +722,31 @@ function i18n_taxonomy_form_all_localize(&$item) {
+      $result = db_select('taxonomy_term_data', 'td')
+        ->fields('td', array('tid', 'name', 'vid', 'language'))
+        ->condition('td.i18n_tsid', $i18n_tsid)

Only use db_select if you have to (dynamic queries, node access, ...) because it is slower than db_query().

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -722,33 +722,31 @@ function i18n_taxonomy_form_all_localize(&$item) {
+      foreach ($result as $term) {
+        $translations[$i18n_tsid][$term->language] = $term;

Can be written as:

$translations[$i18n_tsid] = $query->fetchAllAssoc('language');

Powered by Dreditor.

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -722,33 +722,25 @@ function i18n_taxonomy_form_all_localize(&$item) {
+    $translations = array(
+      $i18n_tsid => db_query($sql, array(':i18n_tsid' => $i18n_tsid))->fetchAllAssoc('language'),

This means that you re-create the complete array every time so the static cache is pretty much useless. You need "$translations[$i18n_tsid] = ... ".

Powered by Dreditor.

Yes, this looks good now.

Just wondering, is this function never actually used anywhere in the i18n project?

Ok great, then let's get this in :)

We may later use translation set functions (i18n_translation) for this, but anyway, better to have a working api function than a broken one.

Committed, thanks.

Keeping our list clean.

Yes, sorry I had missed that too.

Anyway, for this function, I think we should re-purpose it to work just as translation_node_get_translations() taking a tid argument, or a full term object, which I think could be handy for other functions here, as you could iterate over the resulting array, etc.. http://api.drupal.org/api/drupal/modules--translation--translation.modul...

Btw, there's also i18n_taxonomy_translation_set_load(), which is the one to be used here, it is mostly a specific wrapper for taxonomy.

Good cleanup. Thx committed in 4e9f16c