PHP notices when enabling views_litepager [#1072068]

Hi there,

We're about to deploy this module on drupal.org (lucky you!). ;) See these issues for more:
#1066324: Use views_litepager for versioncontrol commitlog views
#1068490: Use views_litepager as pager for all views

I've been tasked with getting this module in shape for deployment. Local testing revealed a handful of PHP notices that appear regularly as soon as you enable the module and start using it. I'll post a patch in a few minutes, just wanted to get the issue open about it.

Comment	File	Size	Author
#1	1072068-1.views_litepager_php_notices.patch	1.31 KB	dww

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dww

we/he/they

CreditAttribution: dww commented 24 February 2011 at 18:57

Status:

Active

» Needs review

File	Size
1072068-1.views_litepager_php_notices.patch	1.31 KB

Comment #2

nrambeck CreditAttribution: nrambeck commented 24 February 2011 at 20:12

Great. The patch looks fine to me. I ran it through my local environment. After giving the module a fresh once-over, the only other thing I see is that it doesn't have a dependency on Views defined in the .info file. I'm not sure if that is necessary or not. Nothing breaks if Views is not installed, but obviously the module is useless without Views.

Is this patch something that needs to be committed right away? Let me know.

Comment #3

dww

we/he/they

CreditAttribution: dww commented 24 February 2011 at 21:33

For today's deployment, I imported your 6.x-2.1 release into our vendor branch deployment system, merged it into our site-specific branch, and committed my patch as a local modification for our site. So no, there's no urgent rush for a 6.x-2.2 release. But yeah, if you wanted to commit this upstream, that's great.

Thanks!
-Derek

Comment #4

dww

we/he/they

CreditAttribution: dww commented 24 February 2011 at 21:40

p.s. No, I don't think you care about the views dependency in the .info file. I noticed that, too, but didn't think it was a problem. I guess it doesn't hurt to add it to be explicit about the dependency, but nothing actually blows up if you have this module and not views. Your call. No strong feeling here. ;)

Thanks,
-Derek