Closed (fixed)
Project:
Boxes
Version:
7.x-1.0-beta3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2011 at 11:34 UTC
Updated:
19 Aug 2011 at 20:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
Grayside commentedWith the goal of the boxes settings being on a separate page?
Comment #2
adamgerthel commentedyes, with the goal of using the standard edit-box page found when using the blocks page for example.
Comment #3
adamdicarlo commentedHere's a solution until whenever this kind of feature is put into the Boxes module.
Stick this in your theme's template.php (and change THEME to your theme name) to turn off all ajax Edit links:
You can also turn them off only for certain boxes (e.g., boxes in a region that inline editing makes no sense for):
Also, the Contextual module is a great way to get groovy hover links on boxes (and blocks, views, nodes, comments) -- for boxes you get a Configure link which takes you to the admin page where you can edit the box content.
Comment #4
dalinPatch attached. If you have the Overlay module enabled this patch should allow you to use that.
Since edit-in-place has so many known issues I've gone so far as to set the default to edit on a separate page.
Comment #5
mrfelton commented+1 for this. The patch in #4 works for me, and gets around the issues that make it impossible to edit boxes inline with WYSIWYG enabled
Comment #6
seanberto commented+1. Inline editing is a great concept, but really challenging with many custom themes.
Comment #7
pixelsweatshop commentedsub. +1
Comment #8
adamdicarlo commentedAwesome patch... works fine for me -- and I have some minor comments since nobody else has piped up.
Whitespace error (extra space at end of line).
I don't think this variable should be set like this -- it doesn't have any effect (and unnecessarily adds a variable to the variables table).
Whitespace error.
Edit: forgot to mention "Edit style" should maybe be more like "Edit location" -- I'm thinking "style" could be confusing to some users.
Comment #9
adamdicarlo commentedWhoops -- I thought that
variable_set()was simply setting the default value. Nevermind -- it makes sense now.Comment #10
dalinMade all proposed changes.
Comment #11
mrfelton commentedNot sure why the above was split into 2 patches. Here is one patch file that combines the 2 patches from #10
Comment #12
dalin#10 is not two patches. It is a regular patch file plus an interdiff which shows what changed compared to #4.
Comment #13
mrfelton commentedI see. Thanks for clearing that up. Then the patch in #11 is the same as the one in #10
Comment #14
jobeirne commentedYour patch has been committed here: http://drupalcode.org/project/boxes.git/commit/3fdd068. I've changed the default editing to happen inline. Thanks!