Terminate CSS comment in layout.css [#106439]

Comment	File	Size	Author
#8	zen-comment-close.patch	568 bytes	dmitrig01
#3	layout-070129.patch	188 bytes	rport

Comment #1

alanburke CreditAttribution: alanburke commented 16 January 2007 at 22:18

Looks like cruft to me
Should have been commented if it were needed.
Roll away...

Log in or register to post comments

Comment #2

jjeff CreditAttribution: jjeff commented 17 January 2007 at 04:44

I'm not seeing this. Can you give me a line number or a context?

Log in or register to post comments

Comment #3

rport CreditAttribution: rport commented 29 January 2007 at 13:28

Assigned:	Unassigned	» rport
Status:	Active	» Needs review

File	Size
layout-070129.patch	188 bytes

Hmm...

A quick look at layout.css shows this exists on or near line 96 (the very bottom) its a quick fix, i've attached a patch for review.

rport

Log in or register to post comments

Comment #4

BioALIEN CreditAttribution: BioALIEN commented 18 February 2007 at 18:39

Has this been committed yet?

Log in or register to post comments

Comment #5

plhosk CreditAttribution: plhosk commented 20 February 2007 at 02:00

This patch, which effectively uncomments the bottom 3 lines of layout.css, breaks the footer in the zen-fixed theme. It causes the footer to take up as much space as in the zen non-fixed theme.

Log in or register to post comments

Comment #6

rport CreditAttribution: rport commented 22 February 2007 at 08:43

I suspect from reading this that the area affected should have been commented out however the terminating */ was left out (see below).

Here is a copy of the relevant section of code;

/*
body.sidebar-left  #footer {
  margin-left: -210px;
}

body.sidebar-right #footer {
  margin-right: -210px;
}

body.both-sidebars #footer {
  margin: 0 -210px;
}

Over to jjeff to consider this and resolve the matter...

Is this some legacy code that should be removed, not just commented out; or
Is this css for some new feature/idea that is simply missing the block terminator; or

~ rport