I think we're ready for a 6.x-1.0. I'm not familiar with the procedure for when I don't have access to do this directly. Should I tag?

Thanks!

Comments

ezra-g’s picture

ezra-g commented

I've tagged for 6.x-1.0 - I think I just can't make the release. Here's what the notes will look like, from cvs-release-notes.py:

Changes since DRUPAL-6--1-0-RC6:

  • task #341920 by dww, Eirik_R and ezra-g: Remove work-arounds for DateAPI limitations once new official releases of DateAPI are out
  • feature #696010 by ezra-g: Alterable signup confirmation drupal_set_message()
  • #597808 by dww: Fixed bug that was causing signup limits to be ignored
    unless the signup_status module is enabled (broken in rc6 by #581652).
  • feature #856604 by ezra-g, jenlampton, jm.federico, coltrane: Make event signups visible on user registration form
  • bug #550036 by iva2k: PHP warnings for node without date value
  • #597808 by dww: Fixed bug that was causing signup limits to be ignored
    unless the signup_status module is enabled (broken in rc6 by #581652).
  • feature #856810 by ezra-g: Option to return array from theme_signup_user_form()
  • bug #370397 by wesley_2mpact and ezra-g: All anonymous signups cancelled when any user is deleted
  • bug #605594 by markus_petrux and ezra-g: node_load() during signup's node_save() breaks node data cached by CCK
  • #594686 by dww: Split all default views into their own separate files.
  • task #670944 by mlsamuelson: Provide means to reset node_load()'s static node caching when calling signup_sign_up_user()
  • feature #656250 by Peter Bex, maverick14: Add SID field Views and Views token integration
  • bug #865108 by dooug: Minor typo - Views integration signup.theme -> views/signup_form.inc
  • #128362 by albertczyk: Updated Spanish translation.
  • german translation, german Speakers: please check spelling, based on 6.x-1.0-rc6
  • feature #658214 by Dave Reid: Changed Add vertical tabs support.
  • updated .pot
  • bug #633636 by Magnus: Untranslatable strings in date.inc
  • #592202 by dww: Added a pager and increased items per page on default views.
  • german translation, updated, complete
  • bug #676276 by keystr0k and ezra-g: Signup not closed when limit reached
  • #226204 by dww: Exposed the numeric signup ID (unique site-wide) as a token.
  • bug #858592 by maikeru: Signup Administration Page Error with Postgres
  • task #582986 by dww and ezra-g: Make views a required dependency and ditch non-views code
  • bug #719188 by ezra-g: Admins should be able to sign up users regardless of their permissions
dww’s picture

dww
we/he/they
commented
Status: Active » Needs review

Given the vast flurry of activity in this queue (HURRAY FOR THAT!!!), I think I'd feel a lot better with rc7 than an official 1.0 release. We can still sync the DRUPAL-6--1 branch to HEAD and start porting to D7 there, but it seems wrong to go from an RC from over a year ago to a 1.0 with tons of new changes in between. ;) Maybe I'm being dumb. Feel free to push back if you disagree -- I'm open to a discussion. But, I'd feel better about an RC and then a 1.0 release with basically no changes from RC7 after a week if RC7 doesn't result in any new bug reports in the queue. Sound like a plan?

ezra-g’s picture

ezra-g commented

I feel like the content of the changes matters more than that it was a year ago, and that while there are a lot of changes, it's not unusual to have releases with many changes.

Given that whatever we release is likely to have some bugs, I'm don't think we should plan to re-release a week later, especially if we're anticipating no changes. Folks will be less likely to take the trouble to upgrade and will be on an RC that is not subject to SAs (as they've been for the entirety of D6) until we have a more compelling release.

We can always do 1.1 ;).

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I think it's better to do either one of these soon than let the issue sit.

Since January 3rd (i.e. all those commits in the dev release) there's two issues with activity: #589104: Site-wide default settings don't warn you that they only operate on new nodes, not existing ones and #939658: Hide signup-link when closed?. Neither seems like a show-stopper.

I can see both sides of this argument - creating a ".0" right after a lot of changes is not a best practice for stability from a "release engineering" perspective. On the other hand, this module has had a lot of RCs and folks just want the stable. Let's give it to them and release a 1.1 shortly after if necessary. Especially now that 7.0 is out it feels a little weird to do yet another RC.

dww’s picture

dww
we/he/they
commented

@greggles: Ezra knows this from IRC, but when I tried to setup a clean test site (using http://drupal.org/project/cckdatetest), the site would WSOD on any signup-related page. ;) It might just be something my test site is doing wrong, but it was worrisome enough that I didn't want to roll the release just yet. Ezra said he was going to look into it, but I haven't heard back. So, for now, this still is in "needs review", until either I get a chance to figure out WTF is up with my test site, or enough other folks can reliably verify that the DRUPAL-6--1-0 tag works fine, there are no upgrade issues from RC6, etc.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Fair enough. I just tried out a few things and was unable to get a WSOD.

I did stumble across #858592-7: Signup Administration Page Error with Postgres.

ezra-g’s picture

ezra-g commented

@dww, I tried to reproduce this just before you logged out of IRC and wasn't able to.

With http://drupal.org/project/cckdatetest, it seems like the .inc files that do Date API testing haven't seen a commit in 2 years. Is it possible they're not compatible with the current Date API? If so, #341920: Remove work-arounds for DateAPI limitations once new official releases of DateAPI are out might explain breaking that.

Perhaps we need another tester?

MasterChief’s picture

MasterChief commented

Hi ezra-g!

I think before making a release, you must look at this issue :

http://drupal.org/node/393278

It's an important feature and this issue was opened the 6th march 2009!

Look at the #9 message, dww proposed the best solution i think.

Thank you for your work.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Perhaps it is an important issue (especially to you), but it's also a feature. In my opinion we shouldn't hold back a 1.0 release for a feature.

ezra-g’s picture

ezra-g commented
Status: Needs review » Reviewed & tested by the community

I committed greggles' patch from #858592: Signup Administration Page Error with Postgres.

I would prefer to roll an RC7 than let this issue sit for longer.

dww’s picture

dww
we/he/they
commented
Version: 6.x-1.x-dev » 6.x-1.0
Status: Reviewed & tested by the community » Fixed

Figured out the problem with my cckdatetest site: http://drupal.org/cvs?commit=477798 duh...

After that, things seemed to be working. I didn't do any exhaustive testing. I did notice #1020544: Reminder email logic broken for untimed events but that didn't seem important enough to delay this any further.

I also finished the job from #1016134: Remove signup translations from CVS. After that, I moved the DRUPAL-6--1-0 tag, and created the 6.x-1.0 release node.

WHOOT!

Thanks again to everyone who helped make this possible, especially ezra-g!!!

ezra-g’s picture

ezra-g commented

Hooray :D !

Thanks, dww!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.