FileTransfer doesn't properly handle any advanced settings nor the ssh username

I have tested the patch with ssh connection and it works without problems.
thanks...

This demonstrates the test coverage for this case. Test should be extended or fixed too

I think all this #parents stuff is ugly and madness. The thing chx was trying to avoid was having the FileTransfer::factory() methods know about the nested structure of the $settings array. However, a) we already handle that in _authorize_filetransfer_connection_settings_set_defaults() and b) each class is responsible for its own settings form, so it should know the structure of the values of that form and be able to deal with it. You could hypothetically imagine a case where you'd have form element name collisions if we just try to flatten everything into a single array. If the settings form is nested, let the $settings array remain nested and make the same class that gave us that form know how to find the values it needs. IMHO, the attached is a lot cleaner than the original patch.

Either way, this patch is touching the same code as #1009162: Can't use SSH connection method at all so I marked that duplicate with this.

More precise and helpful title. ;)

chx's rtbc doesn't sound like "I tested this in the following ways and it works for me."

I need one of those.

I just applied this and tried to install something.

Result: Installed google_analytics successfully.

Regular xampp stack...

The code looks correct to me, but I don't have a system set up to actually test installations via ftp or ssh.

Just set up a system to test with FTP on a non-standard port. Was able to install a module from d.o successfully with no warnings. (SSH untested, but a manual review of the code shows that changes made were identical to that for FTP).

Awesome, thanks a lot for the testing. I will also give this another spin on DreamHost tomorrow or Tuesday, which will test the SSH side of things.

Committed to HEAD.

SSH is also working, tested with the patch at #8.

thanks...