Comments

chx’s picture

Priority: Normal » Minor
StatusFileSize
new737 bytes

Status: Needs review » Needs work

The last submitted patch, 1: insanity.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new21.29 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2322809_18.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new27.83 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2322809_24.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new61.36 KB

Status: Needs review » Needs work

The last submitted patch, 7: path_validator-2323721-54.patch, failed testing.

chx’s picture

StatusFileSize
new623 bytes
chx’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 2320269_9.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new951 bytes

Status: Needs review » Needs work

The last submitted patch, 12: shuffle.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new1015 bytes
new1015 bytes
new1015 bytes
new1015 bytes
new1015 bytes
chx’s picture

StatusFileSize
new17.84 KB

Status: Needs review » Needs work

The last submitted patch, 15: 2346189_48.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new14.59 KB

Status: Needs review » Needs work

The last submitted patch, 17: router-1.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new1.02 MB

for now, CartesianAssociativeProduct is in Drupal\Component\Utility let's hope it gets merged upstream.

Status: Needs review » Needs work

The last submitted patch, 19: 2320269_19.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new1.02 MB

Status: Needs review » Needs work

The last submitted patch, 21: 2320269_21.patch, failed testing.

chx’s picture

StatusFileSize
new1.02 MB
new820 bytes

filterRoutesPerRequest was a) JOINing on route_filter instead of {route_filter} b) why JOIN, the point is to be fast and everything is in one table. I discovered a much bigger bug though, that is in HEAD, attaching a patch.

If 23_1 is a no-go then we need to figure a better way to figure out what to filter. I guess

$paths = [];
foreach ($routes as $route) {
  $paths[$route->getPath()] = isset($paths[$route->getPath()]);
}
$needs_filter = array_keys(array_filter($paths));
chx’s picture

Status: Needs work » Needs review

The last submitted patch, 23: 2320269_23.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 23: 2320269_23_1.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.03 MB

Status: Needs review » Needs work

The last submitted patch, 27: router-27.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.03 MB
benjy’s picture

StatusFileSize
new1.03 MB

Status: Needs review » Needs work

The last submitted patch, 30: router-30.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.04 MB

Status: Needs review » Needs work

The last submitted patch, 32: router-31.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.03 MB

Status: Needs review » Needs work

The last submitted patch, 34: router-32.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.03 MB
chx’s picture

StatusFileSize
new46.49 KB

Removed hoa in favor of my own optimized (not only smaller but faster) CartesianProduct with a test, changed the fetching in getRoutesByPath to only fetch for one path only.

Status: Needs review » Needs work

The last submitted patch, 37: 2320269_37.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new47.18 KB
chx’s picture

StatusFileSize
new47.05 KB

The last submitted patch, 39: 2320269_39.patch, failed testing.

benjy’s picture

StatusFileSize
new55.39 KB

Status: Needs review » Needs work

The last submitted patch, 42: router-41.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new54.26 KB

Status: Needs review » Needs work

The last submitted patch, 44: router-42.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new16.11 KB
chx’s picture

StatusFileSize
new15.47 KB
benjy’s picture

StatusFileSize
new1.36 KB

Status: Needs review » Needs work

The last submitted patch, 48: 2363647-12.patch, failed testing.

znerol’s picture

Status: Needs work » Needs review
StatusFileSize
new139.99 KB

Status: Needs review » Needs work

The last submitted patch, 50: 2324055-66+2376039-8.diff, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new755 bytes
benjy’s picture

StatusFileSize
new40.11 KB

Status: Needs review » Needs work

The last submitted patch, 53: 2427335-50.patch, failed testing.

chx’s picture

StatusFileSize
new1.21 KB
tim.plunkett’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 55: 2320269_55.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new1.25 KB

Status: Needs review » Needs work

The last submitted patch, 58: access_for_redirect.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new2.18 KB

Status: Needs review » Needs work

The last submitted patch, 60: access_for_redirect.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new8.68 KB

Status: Needs review » Needs work

The last submitted patch, 62: 2320269_62.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new9.04 KB

Status: Needs review » Needs work

The last submitted patch, 64: 2320269_63.patch, failed testing.

chx’s picture

StatusFileSize
new14.96 KB
chx’s picture

Status: Needs work » Needs review
StatusFileSize
new14.96 KB
chx’s picture

StatusFileSize
new15.28 KB

Status: Needs review » Needs work

The last submitted patch, 68: 2320269_68.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
StatusFileSize
new8.62 KB

Status: Needs review » Needs work

The last submitted patch, 70: 2320269_69.patch, failed testing.

The last submitted patch, 67: 2320269_67.patch, failed testing.

Status: Needs work » Needs review

isntall queued 70: 2320269_69.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 70: 2320269_69.patch, failed testing.

The last submitted patch, 67: 2320269_67.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dpi’s picture

Status: Needs work » Closed (won't fix)

Dead