[D7] Ideate

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmanvendrakot2310561git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Got some Drupal standard errors in pareview.sh (http://pareview.sh/pareview/httpgitdrupalorgsandboxmanvendrakot2310561git). Fix those as per instruction.

Manual Review

Individual user account

Yes.

No duplication

Yes.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

No

3rd party code

No.

README.txt/README.md

No: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

No

Secure code

Yes

1. Remove the master branch.
2. Remove the .sass-cache from git

Hello,

I have checked your theme thoroughly and got a lot of errors and bugs:

1. There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732
2. In ideate.info file remove this lines.
   
   

   ; Information added by Drupal.org packaging script on 2014-07-16<br/>
   version = "7.29"<br/>
   project = "drupal"<br/>
   datestamp = "1405543132"

   
   This line will be automatically added by drupal package script when you make a release version.

3. When enable the theme, In settings page I got both option is un-select in Content width. The fixed width should be selected by default according to your theme css. (Ref ideate1.jpg)
4. When I change fixed to fluid width the settings not showing effect in frontend. Always fixed width.
5. In higher resolution (> 1300px), I got the left sidebar have css problem (only left sidebar). Mean left sidebar and content area have not any gap and side bar css problem.(Ref ideate2.jpg)
6. Same problem occur when I have only right sidebar.
7. When I have both sidebar then the styles ok. But have css problem in higher resolution (> 1300px).
8. In logged in and logged out mode the sidebar have css problem in higher resolution(> 1300px). (Ref ideate3.jpg)
9. In responsive view, the left sidebar disappear (only left sidebar). (Ref ideate4.jpg)
10. Also have same problem with right sidebar(only right sidebar). (Ref ideate5.jpg)
11. With both sidebar the responsive system ok.
12. Form your code, I see you use Drupal core color module. But when I enable the color module the site logo changed with the drupal default logo. (Ref ideate7.jpg)
13. I have chose a color scheme form the dropdown, save and clear the site full cache. But can't see any color change in frontend. So, the color module based functionality is not working. (Ref ideate6.jpg and ideate7.jpg)
14. In retina based mobile device like, iPhone 5 the responsive is not working perfectly.
15. Can't find out the viewport meta tag that is needed for responsive design. So, the responsive design will not work across all the devices.

Codding and others(Minor):

1. In ideate_preprocess_maintenance_page hook don't call another hook like ideate_preprocess_html. Simply create a seperate function and call in both hooks.
2. in css folder a copy style - Copy.css exist, remove it cause it is unnecessary.
3. Readme is not complete. There is no instruction that how to configure the theme.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.