Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Bot abuse for #2099131: Use #pre_render pattern for entity render caching.
Comment | File | Size | Author |
---|---|---|---|
#41 | interdiff.txt | 3.5 KB | effulgentsia |
#41 | pre-render-2099131-216-testfix1.patch | 143.3 KB | effulgentsia |
#40 | interdiff.txt | 1.37 KB | Wim Leers |
#40 | pre-render-2099131-200-testfix2.patch | 145.18 KB | Wim Leers |
#38 | interdiff.txt | 889 bytes | Wim Leers |
Comments
Comment #1
catchComment #3
catchComment #5
catchComment #6
catchComment #9
catchComment #10
catchComment #13
catchComment #15
catchComment #16
catchComment #18
catchComment #20
catchComment #21
catchComment #23
catchWIP for removing $entity->content
Comment #25
catchComment #27
Wim LeersStraight reroll, chasing HEAD.
Comment #29
Wim LeersThis should fix many (if not most) exceptions.
Comment #30
Wim LeersForgot the (ridiculous) interdiff. :)
Comment #31
Wim LeersThis should also help quite a bit: fixes position of node links and unbreaks rendering of comments.
Comment #33
Wim LeersAnd another one that should help significantly: fixes all
hook_entity_view()
,hook_entity_view_alter()
and friends' hook implementations and documentation. (Those "friends": the node-, comment-, taxonomy term- and user-specific variants of them.)Comment #36
Wim LeersLooking at #31, #33 should be *almost* green. I think this small addition will make it completely green.
… and when I wanted to post this, #33 had just come back as very red. The problem is that I renamed a few things for consistency and forgot to include that part in the patch.
Hopeful this one will be green!
Comment #37
Wim LeersHurray, green!
#36 is re-posted to the main issue at #2099131-128: Use #pre_render pattern for entity render caching.
Comment #38
Wim LeersNew problem, see #2099131-199: Use #pre_render pattern for entity render caching and the few preceding patches.
This is an attempt to fix that last test failure. I suspect something is wrong with testbot's cache tag invalidation.
Comment #40
Wim LeersThis should be the one.
Comment #41
effulgentsia CreditAttribution: effulgentsia commentedI'm reviewing #2099131-216: Use #pre_render pattern for entity render caching and don't get why our cache tag collection is incompatible with elements generated in #pre_render. Curious what tests fail when we remove the workaround. Interdiff is relative to that patch.
Comment #54
quietone CreditAttribution: quietone at PreviousNext commentedI assume this is no longer needed as the issue being tested is fixed.