Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 12.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

project update bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new63.75 KB
new12.25 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version dev-main, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-843071

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha2
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: dev-main

kieran.cott made their first commit to this issue’s fork.

kieran.cott’s picture

Assigned: Unassigned » atowl
Issue summary: View changes

It doesn't look like the bot has opened any MR here, so I've created a new fork and addressed this in a separate MR.

I've tried to keep these changes version-tolerant by using Drupal 12 APIs when present but including callback/constant fallbacks for older versions of core. If we want to drop support for certain older versions, we can probably clean up some of these if-else blocks.

Addresses core version metadata, removed file URL helpers, file exists enum, default filter format lookup, optional Smart IP/Domain hard references, category form return value, D7 migration source base class, and the kernel test $modules visibility.

project update bot’s picture

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.0.0-beta1, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-848511

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha2
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: 1.0.0-beta1
kieran.cott’s picture

Issue summary: View changes
Status: Needs review » Active
project update bot’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new3.25 KB
new79.97 KB
new8.41 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 12 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 12.

Currently Drupal Rector, version 1.0.0-beta7, cannot fix all Drupal 12 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 12 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #12-864040

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 5.0.0-alpha2
  2. mglaman/phpstan-drupal: 2.0.15
  3. palantirnet/drupal-rector: 1.0.0-beta7

kieran.cott’s picture

Issue summary: View changes

Merged MR 188 to fix the merge train blockers, but this still needs work for comments #6 and #8, as well as any further issues raised by project update bot.

Still no MR raised by the bot, so will create another MR to include these and future Drupal 12 compatibility changes in.

kieran.cott changed the visibility of the branch 3597964-drupal-12-compatibility-follow-up to hidden.

kieran.cott changed the visibility of the branch 3597964-automated-drupal-12 to hidden.

drunken monkey made their first commit to this issue’s fork.

drunken monkey’s picture

This change broke module installation on Drupal 11.4+ as _eu_cookie_compliance_get_default_filter_format() would return a FilterFormatInterface object instead of a string.
Should be fixed in this MR.

kieran.cott’s picture

Nice one @drunken monkey, great spot - thanks for the fix.