[ignore] support issue for the core patch

If this goes into Drupal 8.7 core, there's no need for 8.5 and 8.6 compatibility of course. This addresses most of that.

#2 removed all mentions of 8.5, 8.6 or 8.7. Except for three. Those in:

1. \Drupal\jsonapi\ForwardCompatibility\Normalizer\DateTimeIso8601Normalizer
2. \Drupal\jsonapi\ForwardCompatibility\Normalizer\DateTimeNormalizer
3. \Drupal\jsonapi\ForwardCompatibility\Normalizer\TimestampNormalizer

Because we had been assuming since June that #2926508: Add DateTimeNormalizer+TimestampNormalizer, deprecate TimestampItemNormalizer: @DataType-level normalizers are reusable by JSON:API would surely go into Drupal 8.6, and definitely in 8.7. It still hasn't landed 😱 😞 So for now, we need to keep those 3 classes. That means we should start pushing #2926508 forward again, it risks blocking JSON:API.

#2843147-79: Add JSON:API to core as a stable module includes #4.

Addresses #2843147-94: Add JSON:API to core as a stable module points 1 and 3.

Fix CS violations.

Thanks for being so diligent 👌

#3021277: Test failures on 8.7 since #2869426 landed, RC4 is out, time for an updated core patch, and hence time for addressing #9.

For https://www.drupal.org/project/jsonapi/releases/8.x-2.1.

#19: great catch!

#2955615: Field properties are not being denormalized introduced this:

    // @todo Make this unconditional once https://www.drupal.org/project/drupal/issues/2957385 lands — JSON:API fixed denormalization of properties in https://www.drupal.org/project/jsonapi/issues/2955615, core's Serialization module still has to follow
    if ($test_module === 'jsonapi_test_field_type') {
      $this->assertSame(static::VALUE_ORIGINAL, $denormalized_entity->field_test->value);
    }

#2957385: FieldItemNormalizer never calls @DataType-level normalizer service' ::denormalize() method landed yesterday, so we can get rid of that todo! 🎉

With #3028970: Audit all @todos and #2965056: Support `include` parameter on relationship routes (turns out it accidentally works on cold caches: fix + test this) having landed, this needed updating. First, rebasing.

Removed a few things that those two issues introduced/changed.

And also fixed one thing that should have been removed together with #20.

D'oh, lol, I queued a 8.6 and 8.5 test for #23. 🤡 Force of habit. I'll queue all possible envs for 8.7 instead :)

You're right, I forgot about #19 while working on this other things … my bad!

#3029626: Use ::class constant instead of string literal where possible landed. :)

#3029704: Follow-up for #3001193: testPostIndividualDxWithoutCriticalBaseFields() fails in some circumstances on PHP 5 landed, which changed the fail in #26 into a pass — that fail was unrelated to this issue/patch :)

One more simplification thanks to #3029704: Follow-up for #3001193: testPostIndividualDxWithoutCriticalBaseFields() fails in some circumstances on PHP 5!

Rebased and merged #3027980-12: [upstream] Move FormatSetter from middleware to a route filter, removing conditionality on Accept header into this patch.

With #2926508: Add DateTimeNormalizer+TimestampNormalizer, deprecate TimestampItemNormalizer: @DataType-level normalizers are reusable by JSON:API having landed, we can remove the forward compatibility layer for that!

Forgot #32's interdiff.

Sure, but that can't happen here, it'll have to happen in #2843147's script, since MAINTAINERS.txt lives in core, not the jsonapi module. Will do!

Rebased. Two additional 8.7-specific hunks were added since #32, which this needs to remove. A few hunks are no longer necessary thanks to the recent core security release backporting certain changes from to 8.5/8.6, which hence already removed some core-minor-conditional logic, leaving less work for this patch.

Rerolled to port #2940383-54: Unify file upload logic of REST and JSON:API, which itself was triggered by #2244513: Move the unmanaged file APIs to the file_system service (file.inc) landing.

The PHP 7 test failed randomly:

1) Drupal\Tests\jsonapi\Functional\EntryPointTest::testEntryPoint
mkdir(): File exists

And the PHP 5 tests are also failing for very surprising reasons:

PHPUnit_Framework_Exception: Argument #2 (No Value) of PHPUnit_Framework_Assert::assertCount() must be a countable or traversable

Retesting both.

Part of #37 landed in HEAD in #3035666: Drupal core compatibility: file_* functions deprecated in Drupal >= 8.7. Rebasing #37.

Also, the PHP 5.5 failures on 8.7 seem to be due to an upstream change in Drupal core. Investigating that in #3035676: Follow-up for #3033123: PHP 5.5 + Drupal 8.7 test runs are suddenly failing.

Root cause for the PHP 5 failures found. Fixed in #3035676: Follow-up for #3033123: PHP 5.5 + Drupal 8.7 test runs are suddenly failing. Retesting #39 on PHP 5.

Rebase to solve conflicts after #3033359: Address Drupal core BC policy gate feedback from @xjm landed.

Updated to take #2940383-60: Unify file upload logic of REST and JSON:API into account: #2940383 won't happen until after JSON:API lands in core, and hence some the changes in #37 that were designed to make the JSON:API core patch be as ready to use #2940383 after it landed can be removed.

Forgot one line.

Rebased #43 on ef520336bd13a0f6ce2b8e714cb1b46a98c849dd.

Gaaahhhh #3000057: Deprecate drupal_set_time_limit() and file_upload_max_size() and move to Environment component just landed. 😞 Will need to fix those deprecation errors first.

Fixed #45 in #3036772: Drupal core compatibility: file_upload_max_size() deprecated in Drupal >= 8.7.

Updated patch.

For #2843147-152: Add JSON:API to core as a stable module. (Sibling patch for #3037682: Address additional Drupal core documentation gate feedback from @xjm.)

Rebased. And one new 8.5-specific thing that needs to be removed for the core patch, due to newly added test coverage.

#49: THANK YOU! 🙏Ported that to the contrib module, resolved conflicts, and made it pass on 8.5 and 8.6 too, not just Drupal 8.7. Credited you, of course. See #3015325-8: [ignore] support issue for the core patch and #3015325-10: [ignore] support issue for the core patch.

This needs a reroll for #3039235: 8.7.x: update anything needed now that taxonomy terms are revisionable and will need another reroll after #3039568: Add a read-only mode to JSON:API.

Rebased.

Most of the necessary new changes already were fixed in the conflict resolutions of #52. This is the only new core-minor-conditional code that was added since b175c3a9fd5cebcb7849de7559f56a73f756d8bc.

#2843147: Add JSON:API to core as a stable module got committed to 8.8, and will be cherry-picked to 8.7 later today 🥳